Skip to content

Refactor AppCDS handling now that we support JEP 483 in addition to AppCDS #46234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 3, 2025
Merged

Refactor AppCDS handling now that we support JEP 483 in addition to AppCDS #46234

merged 2 commits into from
Apr 3, 2025

Conversation

geoand
Copy link
Contributor

@geoand geoand commented Feb 12, 2025 •
edited
Loading

This is potentially a breaking change for extensions, not for users.

@quarkus-bot quarkus-bot

This comment was marked as resolved.

Sign in to view
@geoand geoand requested a review from gsmet February 12, 2025 14:38
@quarkus-bot quarkus-bot bot added area/arc Issue related to ARC (dependency injection) area/core labels Feb 12, 2025
@geoand geoand added release/breaking-change and removed area/core area/arc Issue related to ARC (dependency injection) labels Feb 12, 2025
@quarkus-bot quarkus-bot bot added area/arc Issue related to ARC (dependency injection) area/core labels Feb 12, 2025
@quarkus-bot quarkus-bot

This comment has been minimized.

Sign in to view
@quarkus-bot quarkus-bot

This comment has been minimized.

Sign in to view
@quarkus-bot quarkus-bot

This comment has been minimized.

Sign in to view
gsmet
gsmet reviewed Feb 14, 2025
View reviewed changes
Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry to be that guy (again!) but...

@geoand
Copy link
Contributor Author

geoand commented Feb 14, 2025 •
edited
Loading

Thanks for checking!

I'll fix the points you raised

@geoand
Copy link
Contributor Author

geoand commented Feb 14, 2025

Should be better now

@quarkus-bot quarkus-bot

This comment has been minimized.

Sign in to view
@geoand geoand requested a review from gsmet February 14, 2025 13:59
@geoand
Remove AppCDS generation from core and keep the one in Arc
6e90039 
This is done as Arc is pretty much a requirement for all
applications so we can simplify the AppCDS handling
@geoand
Rename AppCDS build items now that we support JEP 483
416e22b
@quarkus-bot quarkus-bot
Copy link

quarkus-bot bot commented Feb 18, 2025 •
edited by github-actions bot
Loading

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 416e22b.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

Flaky tests - Develocity

⚙️ JVM Tests - JDK 17

📦 extensions/micrometer-opentelemetry/deployment

✖ io.quarkus.micrometer.opentelemetry.deployment.compatibility.MicrometerTimedInterceptorTest.testTimeMethod_Async - History

  • Stream has no elements - java.lang.IllegalArgumentException
java.lang.IllegalArgumentException: Stream has no elements
	at io.quarkus.micrometer.opentelemetry.deployment.common.MetricDataFilter.lastReadingDataPoint(MetricDataFilter.java:236)
	at io.quarkus.micrometer.opentelemetry.deployment.compatibility.MicrometerTimedInterceptorTest.testTimeMethod_Async(MicrometerTimedInterceptorTest.java:126)
	at java.base/java.lang.reflect.Method.invoke(Method.java:569)
	at io.quarkus.test.QuarkusUnitTest.runExtensionMethod(QuarkusUnitTest.java:513)
	at io.quarkus.test.QuarkusUnitTest.interceptTestMethod(QuarkusUnitTest.java:427)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)

⚙️ Maven Tests - JDK 17

📦 integration-tests/devmode

✖ io.quarkus.test.devui.DevUIGrpcSmokeTest.testTestService - History

  • Too many recursions, message not returned for id [388551178] - java.lang.RuntimeException
java.lang.RuntimeException: Too many recursions, message not returned for id [388551178]
	at io.quarkus.devui.tests.DevUIJsonRPCTest.objectResultFromJsonRPC(DevUIJsonRPCTest.java:164)
	at io.quarkus.devui.tests.DevUIJsonRPCTest.objectResultFromJsonRPC(DevUIJsonRPCTest.java:167)
	at io.quarkus.devui.tests.DevUIJsonRPCTest.objectResultFromJsonRPC(DevUIJsonRPCTest.java:167)
	at io.quarkus.devui.tests.DevUIJsonRPCTest.objectResultFromJsonRPC(DevUIJsonRPCTest.java:167)
	at io.quarkus.devui.tests.DevUIJsonRPCTest.objectResultFromJsonRPC(DevUIJsonRPCTest.java:167)
	at io.quarkus.devui.tests.DevUIJsonRPCTest.objectResultFromJsonRPC(DevUIJsonRPCTest.java:167)
	at io.quarkus.devui.tests.DevUIJsonRPCTest.objectResultFromJsonRPC(DevUIJsonRPCTest.java:167)

@geoand
Copy link
Contributor Author

geoand commented Feb 27, 2025

@gsmet is there anything else you would like to see for this one?

@geoand
Copy link
Contributor Author

geoand commented Apr 3, 2025

Ping

gsmet
gsmet approved these changes Apr 3, 2025
View reviewed changes
Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, no, sorry, I thought we had merged this one ages ago.

@gsmet gsmet merged commit f206fa8 into quarkusio:main Apr 3, 2025
55 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.22 - main milestone Apr 3, 2025
@geoand
Copy link
Contributor Author

geoand commented Apr 3, 2025

np :)

@geoand geoand deleted the appcds-refactor branch April 3, 2025 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gsmet gsmet gsmet approved these changes

Assignees
No one assigned
Labels
area/arc Issue related to ARC (dependency injection) area/core release/breaking-change triage/flaky-test
Projects
None yet
Milestone
3.22 - main
Development

Successfully merging this pull request may close these issues.
2 participants
@geoand @gsmet