Skip to content

BUG: Catch all missing data exceptions when computing dividend ratios #1507

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 22, 2016
Merged

BUG: Catch all missing data exceptions when computing dividend ratios #1507

merged 2 commits into from
Sep 22, 2016

Conversation

yankees714
Copy link
Contributor

No description provided.

@coveralls
Copy link

coveralls commented Sep 22, 2016 •
edited
Loading

Coverage Status

Coverage remained the same at 86.548% when pulling 2c90d0d on calc-dividend-ratios-handle-all-no-data into 9d7049a on master.

@ehebert
Copy link
Contributor

ehebert commented Sep 22, 2016

This works, seems like there should be a common base for those exceptions though.
e.g. NoDataAfterDate could subclass NoDataOnDate.

@coveralls
Copy link

coveralls commented Sep 22, 2016 •
edited
Loading

Coverage Status

Coverage remained the same at 86.548% when pulling 4e45a4d on calc-dividend-ratios-handle-all-no-data into 9d7049a on master.

@yankees714 yankees714 merged commit ca5f98b into master Sep 22, 2016
@yankees714 yankees714 deleted the calc-dividend-ratios-handle-all-no-data branch September 22, 2016 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ehebert ehebert ehebert approved these changes

Assignees

@ehebert ehebert

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yankees714 @coveralls @ehebert