Added QCS6490 support for Watchdog test #71
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit is to add QCS6490 support to watchdog test as it does not support upstream watchdog Signed-off-by: Vamsee Narapareddi <[email protected]>
smuppand
reviewed
Jun 5, 2025
| @@ -44,8 +44,13 @@ if [ -e /dev/watchdog ]; then | |||
| log_pass "$TESTNAME : Test Passed" | |||
| echo "$TESTNAME PASS" > "$res_file" | |||
| else | |||
| log_fail "/dev/watchdog node is not present." | |||
There was a problem hiding this comment.
if /dev/watchdog is missing, test could still pass if the kernel configs are correct. But ideally.
- Validate presence of a watchdog driver (eg: module loaded or DT node)
smuppand
reviewed
Jun 5, 2025
| log_fail "$TESTNAME : Test Failed" | ||
| echo "$TESTNAME FAIL" > "$res_file" | ||
| CONFIGS="CONFIG_WATCHDOG CONFIG_ARM_SMC_WATCHDOG CONFIG_WATCHDOG_HANDLE_BOOT_ENABLED" | ||
| check_kernel_config "$CONFIGS" || { |
There was a problem hiding this comment.
better check for non-zero with condition for better debuggin in CI.
if [ $? -ne 0 ]; then log_fail "$TESTNAME : Required kernel configs missing" echo "$TESTNAME FAIL" > "$res_file" exit 1 fi
smuppand
requested changes
Jun 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit is to add QCS6490 support to watchdog test as it does not support upstream watchdog