-
Notifications
You must be signed in to change notification settings - Fork 14
Add: test script for validating Qualcomm HWRNG functionality #36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Adds initial test script and supporting documentation to validate qcom_hwrng integration and functionality. Signed-off-by: naveenkumar s <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update your signed-off-by to use first and last name.
# Copyright (c) Qualcomm Technologies, Inc. and/or its subsidiaries. | ||
# SPDX-License-Identifier: BSD-3-Clause-Clear | ||
|
||
#!/bin/sh |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please move shebang to the 1st line in the script
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does copyright check fail, if we move shebang to line 1?
Revised script and documentation following review suggestions. Signed-off-by: Naveenkumar Suresh <[email protected]>
@mwasilew In the latest commit, I expanded the last name and signed off, but the DCO Signed off check is failing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please rebase this feature branch on top of latest main. This helps to review the PR easier and merge.
Adds initial test script and supporting documentation to validate qcom_hwrng integration and functionality.