Added Display IGT Test #28

manasab-qli · 2025-05-14T05:24:48Z

Description:
This script automates the validation of authentication mechanisms within the IGT Core framework. It performs a series of tests to ensure that the authentication processes are functioning correctly and securely. The script captures detailed logs and provides a summary of the test results.

mwasilew

Commit message is missing

mwasilew · 2025-05-14T05:47:12Z

Runner/suites/Multimedia/Display/core_auth/run.sh

+echo "Checking if dependency binary is available"
+
+# Set the library path for the IGT tests
+LD_LIBRARY_PATH=/data/igt/lib


Please check whether the path exists

added the check in next commit

mwasilew · 2025-05-14T05:47:23Z

Runner/suites/Multimedia/Display/core_auth/run.sh

+export LD_LIBRARY_PATH
+
+# Navigate to the directory containing the IGT tests
+cd /data/igt/tests/


Please check whether the path exists

added the check in next commit

mwasilew · 2025-05-14T05:48:22Z

Runner/suites/Multimedia/Display/core_auth/run.sh

+cd /data/igt/tests/
+
+# Run the core_auth test and log the output to a file
+./core_auth 2>&1 | tee /data/core_auth_log.txt


Please ensude /data/ directory exists before saving logs there.

added the check in next commit

mwasilew · 2025-05-14T05:48:53Z

Runner/suites/Multimedia/Display/core_auth/run.sh

+else
+	# If "SUCCESS" is not found, print that the test failed
+	log_pass "$TESTNAME : Test Failed"
+	echo "$TESTNAME Fail" > $test_path/$TESTNAME.res


s/Fail/FAIL/

added the check in next commit

Runner/suites/Multimedia/Display/core_auth/run.sh

mwasilew · 2025-05-14T05:50:19Z

Runner/suites/Multimedia/Display/core_auth/Display_Readme_IGTTestValidation.md

@@ -0,0 +1,68 @@
+Sure, here is a README for the IGT Core Auth Test:


? Seems unneccessary

added the check in next commit

mwasilew · 2025-05-14T05:51:36Z

Runner/suites/Multimedia/Display/core_auth/Display_Readme_IGTTestValidation.md

+1. Copy the script to your target system and make it executable:
+
+```bash
+chmod +x igt_core_auth_test.sh


this file is not part of the PR

added the check in next commit

mwasilew · 2025-05-14T05:51:53Z

Runner/suites/Multimedia/Display/core_auth/Display_Readme_IGTTestValidation.md

+2. Run the script:
+
+```bash
+./igt_core_auth_test.sh


This file is not part of the PR

this is renamed to run.sh to maintain the same convention.
readme will also updated in the same way. in the commit this has been taken care

mwasilew · 2025-05-14T05:53:37Z

Runner/suites/Multimedia/Display/core_auth/Display_Readme_IGTTestValidation.md

+## Output
+
+- **Test Logs**: Stored in individual files for each test variant.
+- **Kernel Logs**: Captured via `dmesg` and `syslog`.


dmesg and syslog are not used anywhere in the test script

added the check in next commit

mwasilew · 2025-05-14T07:40:12Z

Please squash the commits. There is no need to have 3 instead of 1

mwasilew

Please squash the commits and edit resulting commit message. Initial commit message is currently empty.

manasab-qli · 2025-05-22T04:47:20Z

Please squash the commits and edit resulting commit message. Initial commit message is currently empty.

Let me address this

mwasilew

Commit message is missing.

mwasilew · 2025-05-22T08:14:06Z

Runner/suites/Multimedia/Display/core_auth/run.sh

@@ -0,0 +1,54 @@
+#!/bin/sh
+# Import test suite definitions


Please add Qualcomm copyright and SPDX header.

mwasilew · 2025-05-22T08:14:15Z

Runner/suites/Multimedia/Display/core_auth/Display_Readme_IGTTestValidation.md

@@ -0,0 +1,63 @@
+# IGT Core Auth Test Script


Please add Qualcomm copyright and SPDX header.

Signed-off-by: Manasa Bethapalli <[email protected]>

mwasilew

Please address the shellcheck issues:

In ./Runner/suites/Multimedia/Display/core_auth/run.sh line 4:
#!/bin/sh
^-- SC1128 (error): The shebang must be on the first line. Delete blanks and move comments.


In ./Runner/suites/Multimedia/Display/core_auth/run.sh line 6:
. $(pwd)/init_env
  ^----^ SC2046 (warning): Quote this to prevent word splitting.


In ./Runner/suites/Multimedia/Display/core_auth/run.sh line 26:
    # Set the LD_LIBRARY_PATH environment variable
^-- SC1018 (error): This is a unicode non-breaking space. Delete and retype it.
 ^-- SC1018 (error): This is a unicode non-breaking space. Delete and retype it.
  ^-- SC1018 (error): This is a unicode non-breaking space. Delete and retype it.


In ./Runner/suites/Multimedia/Display/core_auth/run.sh line 27:
    export LD_LIBRARY_PATH=/data/igt/lib
^-- SC1018 (error): This is a unicode non-breaking space. Delete and retype it.
 ^-- SC1018 (error): This is a unicode non-breaking space. Delete and retype it.
  ^-- SC1018 (error): This is a unicode non-breaking space. Delete and retype it.


In ./Runner/suites/Multimedia/Display/core_auth/run.sh line 28:
    echo "LD_LIBRARY_PATH is set to /data/igt/lib"
^-- SC1018 (error): This is a unicode non-breaking space. Delete and retype it.
 ^-- SC1018 (error): This is a unicode non-breaking space. Delete and retype it.
  ^-- SC1018 (error): This is a unicode non-breaking space. Delete and retype it.


In ./Runner/suites/Multimedia/Display/core_auth/run.sh line 30:
    echo "Directory either /data/ or /data/igt/lib or both does not exist"
^-- SC1018 (error): This is a unicode non-breaking space. Delete and retype it.
 ^-- SC1018 (error): This is a unicode non-breaking space. Delete and retype it.
  ^-- SC1018 (error): This is a unicode non-breaking space. Delete and retype it.


In ./Runner/suites/Multimedia/Display/core_auth/run.sh line 31:
    exit 1
^-- SC1018 (error): This is a unicode non-breaking space. Delete and retype it.
 ^-- SC1018 (error): This is a unicode non-breaking space. Delete and retype it.
  ^-- SC1018 (error): This is a unicode non-breaking space. Delete and retype it.


In ./Runner/suites/Multimedia/Display/core_auth/run.sh line 35:
cd /data/igt/tests/
^-----------------^ SC2164 (warning): Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

Did you mean: 
cd /data/igt/tests/ || exit

For more information:
  https://www.shellcheck.net/wiki/SC1018 -- This is a unicode non-breaking sp...
  https://www.shellcheck.net/wiki/SC1128 -- The shebang must be on the first ...
  https://www.shellcheck.net/wiki/SC2046 -- Quote this to prevent word splitt...
Error: Process completed with exit code 123.

mwasilew · 2025-05-23T07:33:22Z

Runner/suites/Multimedia/Display/core_auth/run.sh

+# Copyright (c) Qualcomm Technologies, Inc. and/or its subsidiaries.
+# SPDX-License-Identifier: BSD-3-Clause-Clear
+
+#!/bin/sh


shebang must be the first line in the script.

mwasilew · 2025-05-23T07:34:45Z

Runner/suites/Multimedia/Display/core_auth/run.sh

+
+# Print the completion of the test case
+echo "-------------------Completed $TESTNAME Testcase----------------------------"
+


Please remove empty lines at the end of the script

smuppand

@manasab-qli Please ensure that you use the latest skeleton for any test scripts contributed to this repository. Also, make sure to rebase your feature branch onto the latest main branch. This will help streamline the review process and facilitate a smoother merge of your pull request.

manasab-qli assigned mwasilew, smuppand and abbajaj806 May 14, 2025

manasab-qli requested review from mwasilew, smuppand and abbajaj806 May 14, 2025 05:25

manasab-qli unassigned mwasilew, smuppand and abbajaj806 May 14, 2025

abbajaj806 requested a review from vnarapar May 14, 2025 05:35

mwasilew requested changes May 14, 2025

View reviewed changes

manasab-qli requested a review from mwasilew May 14, 2025 06:09

mwasilew requested changes May 20, 2025

View reviewed changes

manasab-qli requested a review from mwasilew May 22, 2025 04:46

manasab-qli force-pushed the main branch 2 times, most recently from 81f53b8 to 9b25648 Compare May 22, 2025 06:42

mwasilew requested changes May 22, 2025

View reviewed changes

added display test

711c69f

Signed-off-by: Manasa Bethapalli <[email protected]>

manasab-qli force-pushed the main branch from 9b25648 to 711c69f Compare May 22, 2025 15:27

mwasilew requested changes May 23, 2025

View reviewed changes

smuppand requested changes Jun 3, 2025

View reviewed changes

		@@ -0,0 +1,68 @@
		Sure, here is a README for the IGT Core Auth Test:


		# Print the completion of the test case
		echo "-------------------Completed $TESTNAME Testcase----------------------------"

Added Display IGT Test #28

Are you sure you want to change the base?

Added Display IGT Test #28

Uh oh!

Conversation

manasab-qli commented May 14, 2025

Uh oh!

mwasilew left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mwasilew commented May 14, 2025

Uh oh!

mwasilew left a comment

Choose a reason for hiding this comment

Uh oh!

manasab-qli commented May 22, 2025

Uh oh!

mwasilew left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mwasilew left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

smuppand left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!