Skip to content

initramfs-test-full: Add more utils #897

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 19, 2025
Merged

Conversation

vivpuar
Copy link
Contributor

@vivpuar vivpuar commented May 19, 2025

Adding the utilities net-tools and rng-tools in 'initramfs-test-full-image.bb'

  • net-tools is required by the scripts in PR#35 in qcom-linux-testkit
  • rng-tools is required by the script to run rngtest

Add the following utilities in 'initramfs-test-full-image.bb'

- net-tools (for connectivity functionality - e.g. ifconfig, netstat,
  route are crucial for network diagnostics and configuration)
- rng-tools (for cryptography, secure communications, and randomness)

Signed-off-by: Vivek Puar <[email protected]>
@lumag
Copy link
Collaborator

lumag commented May 19, 2025

Please add a recipe for the testsuite instead of pulling dependencies manually. Declare all dependencies for a testsuite (including those already being part of the initramfs). Then simply install the testsuite as a part of the initramfs

@ndechesne
Copy link
Contributor

Please add a recipe for the testsuite instead of pulling dependencies manually. Declare all dependencies for a testsuite (including those already being part of the initramfs). Then simply install the testsuite as a part of the initramfs

Why? How is this PR different from what we already have in this image? I don't understand.

@lumag
Copy link
Collaborator

lumag commented May 19, 2025

Please add a recipe for the testsuite instead of pulling dependencies manually. Declare all dependencies for a testsuite (including those already being part of the initramfs). Then simply install the testsuite as a part of the initramfs

Why? How is this PR different from what we already have in this image? I don't understand.

From my PoV we have had a random collection of tools there. If we are using it to run a testsuite, I'd really like to know, which packages are required for the tests and which are just random tools. E.g. I don't want to duplicate the list if Neil starts using our testsuite in QCLT CI

@lumag
Copy link
Collaborator

lumag commented May 19, 2025

Another option might be define a packagegroup. Would that be better from your POV?

@ndechesne
Copy link
Contributor

it's an image, i am fine to keep things simple in there. net-tools and rng-tools are fairly standard utilities, so I am ok to have them listed there. a packagegroup is useful if we need to make several image variants so that we don't repeat the list, IMHO.

Copy link

Test Results

 4 files  ±0   8 suites  ±0   3m 25s ⏱️ ±0s
31 tests ±0  31 ✅ ±0  0 💤 ±0  0 ❌ ±0 
80 runs  ±0  80 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 976b6ad. ± Comparison against base commit 7c50ff6.

Copy link

@lumag lumag enabled auto-merge May 19, 2025 15:14
@lumag lumag merged commit f0d28c4 into qualcomm-linux:master May 19, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants