Skip to content

Fix underflow when current wpm > latest wpm #14995

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

jesus-ramos
Copy link

@jesus-ramos jesus-ramos commented Oct 31, 2021

Description

Fixes an underflow caused by some unsigned math in the WPM calculation.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added the core label Oct 31, 2021
@drashna drashna requested a review from a team October 31, 2021 15:28
@drashna
Copy link
Member

drashna commented Oct 31, 2021

Just a heads up, #13902 may be a better long term solution, and the breaking changes cycle is coming up soon.

@jesus-ramos
Copy link
Author

I must have missed that change when I searched open pulls somehow. That is probably the more correct solution here. Depends on when you want to merge those changes in, feel free to discard this one if you plan to merge that in soon.

@drashna drashna closed this Nov 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants