Skip to content

[WIP] Remove qiskit-algorithms dependency #654

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 22 commits into
base: main
Choose a base branch
from

Conversation

t-imamichi
Copy link
Collaborator

@t-imamichi t-imamichi commented Feb 13, 2025

Summary

WIP. This PR removes qiskit-algorithms dependency based on #639.
After #639 is merged, this PR needs to be rebased onto main branch.

TODO

Details and comments

Classical Optimizers.
This package contains a variety of classical optimizers and were designed for use by
qiskit_algorithm's quantum variational algorithms, such as :class:`~qiskit_algorithms.VQE`.
qiskit_optimization's quantum variational algorithms, such as
:class:`~qiskit_optimization.minimum_eigensolvers.SamplingVQE`.
Logically, these optimizers can be divided into two categories:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Logically, these optimizers can be divided into two categories:

Given that one of the two categories i.e. Global Optimizers has been removed by the changes here the (above) text really needs redoing.

@woodsp-ibm
Copy link
Member

In looking at #662 and doing a quick search on this repo I see that tutorial12 ie 12_quantum_random_access_optimizer.ipynb in line[13] when viewing it here has the following which referred to Qiskit Algorithms - but the url is not where Algorithms docs are published. But given the class has been moved (copied) here the reference needs to be local now.

MinimumEigensolverResult: This object contains the results of running the minimum eigen optimizer such as the VQE on the relaxed problem. It provides information about the eigenvalue, and other relevant details. You can refer to the Qiskit Algorithms documentation for a comprehensive explanation of the entries within this object.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants