Skip to content

Fix for docplex 2.20 #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 4, 2021

Conversation

t-imamichi
Copy link
Collaborator

Summary

Fixes #21

I tested both docplex 2.20.204 and docplex 2.19.202 with test_quadratic_program.py

Details and comments

@woodsp-ibm
Copy link
Member

@t-imamichi Is the Var part of the public API of docplex or some internal class. @adekusar-drl went through a while back to change anything over to using public API (though its not so obvious in some cases) so we could try and avoid breaking any time a new docplex release came out if things had changed. This is of course assuming public API is deprecated etc so one has time to change things. Was it public and if so was it deprecated and we missed it - or was it another breaking change that we had been hoping to avoid going forwards via discussion with the docplex team.

@t-imamichi
Copy link
Collaborator Author

t-imamichi commented Feb 4, 2021

I checked several versions of docplex. mp.linear.Var seems like an internal alias of mp.dvar.Var, which is removed in the latest version. Perhaps, we need to double-check the Docplex API.
http://ibmdecisionoptimization.github.io/docplex-doc/mp/docplex.mp.dvar.html

@woodsp-ibm
Copy link
Member

Perhaps, we need to double-check the Docplex API.

Perhaps we could also reach out to the docplex team to maybe scan through our use of docplex within our code to help out here too. I recall some things we had been looking at not being so obvious from the code/docs as to whether it was really part of what was considered an internal API used within the codebase versus a public API. I would imagine someone from their side looking over what we have would be able to indicate more easily if something were doing was using what was considered internal logic and that there was a better way to do things that we could avoid seeing these breakages.

@manoelmarques manoelmarques merged commit 59c18ea into qiskit-community:master Feb 4, 2021
@t-imamichi t-imamichi deleted the fix-docplex branch February 5, 2021 00:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New version of Docplex breaks QuadraticProgram
3 participants