Skip to content

Pin Qiskit to <2 in next release #904

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 20, 2025
Merged

Conversation

edoaltamura
Copy link
Collaborator

Summary

Pinning Qiskit<2 will avoid breaking changes to affect current installations. This potential effect was raised in #897. The constraint can be removed when QML achieves full compatibility with Qiskit 2.

@edoaltamura edoaltamura added the dependencies 🔗 Involves external dependency libraries label Mar 18, 2025
@woodsp-ibm
Copy link
Member

I am wondering - in the requirements.txt already exists a version limit for qiskit

qiskit>=1.0
scipy>=1.4
numpy>=1.17
scikit-learn>=1.2
setuptools>=40.1
dill>=0.3.4

Would it be better to keep the version restrictions in one place especially since its a direct dependent i.e. qiskit>=1.0,<2.0. I also notice that there is a version limiting on numpy while the constraints.txt has something different.

@edoaltamura edoaltamura added this to the v.0.8.3 milestone Mar 19, 2025
@coveralls
Copy link

Pull Request Test Coverage Report for Build 13954831611

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 90.857%

Totals Coverage Status
Change from base Build 13954824039: 0.0%
Covered Lines: 4482
Relevant Lines: 4933

💛 - Coveralls

Copy link
Member

@woodsp-ibm woodsp-ibm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a comment to this:

The constraint can be removed when QML achieves full compatibility with Qiskit 2.

Before this it has a constraint >=1.0 so that rather than being removed (depending in what removed is exactly) the upper bound could be removed but that's likely then to become the lower bound i.e. >=2.0 I would think.

@edoaltamura edoaltamura merged commit de2cf2c into main Mar 20, 2025
26 of 27 checks passed
@edoaltamura edoaltamura deleted the edoaltamura-pin-qiskit-2 branch March 20, 2025 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies 🔗 Involves external dependency libraries
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants