Skip to content

PyTorch connector refractoring #809

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 25 commits into from
Jul 30, 2024
Merged

Conversation

edoaltamura
Copy link
Collaborator

This addresses points 2 and 3 raised in #787. Also improved PyLint stability by declaring dummy handles when PyTorch is not used.

@edoaltamura edoaltamura self-assigned this Jun 19, 2024
@coveralls
Copy link

coveralls commented Jun 19, 2024

Pull Request Test Coverage Report for Build 9588117194

Details

  • 74 of 99 (74.75%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.8%) to 92.237%

Changes Missing Coverage Covered Lines Changed/Added Lines %
qiskit_machine_learning/connectors/torch_connector.py 74 99 74.75%
Files with Coverage Reduction New Missed Lines %
qiskit_machine_learning/connectors/torch_connector.py 1 80.0%
Totals Coverage Status
Change from base Build 9465953664: -0.8%
Covered Lines: 2020
Relevant Lines: 2190

💛 - Coveralls

@edoaltamura edoaltamura added the on hold 🛑 Can not fix yet label Jul 1, 2024
@edoaltamura edoaltamura removed the on hold 🛑 Can not fix yet label Jul 12, 2024
@edoaltamura edoaltamura added this to the 0.8.0 milestone Jul 15, 2024
@coveralls
Copy link

coveralls commented Jul 29, 2024

Pull Request Test Coverage Report for Build 10159959650

Details

  • 74 of 99 (74.75%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.8%) to 92.237%

Changes Missing Coverage Covered Lines Changed/Added Lines %
qiskit_machine_learning/connectors/torch_connector.py 74 99 74.75%
Files with Coverage Reduction New Missed Lines %
qiskit_machine_learning/connectors/torch_connector.py 1 80.0%
Totals Coverage Status
Change from base Build 10159942692: -0.8%
Covered Lines: 2020
Relevant Lines: 2190

💛 - Coveralls

@edoaltamura edoaltamura merged commit 89792d2 into qiskit-community:main Jul 30, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants