Skip to content
This repository was archived by the owner on Dec 7, 2021. It is now read-only.

Fix recursive optimization #976

Merged

Conversation

stefan-woerner
Copy link
Contributor

Fixing issue #969

@stefan-woerner
Copy link
Contributor Author

stefan-woerner commented May 12, 2020

@manoelmarques @woodsp-ibm Travis fails due to a lint problem with files that are not affected by this PR. Do you know how to solve this? (locally all checks pass)

@woodsp-ibm
Copy link
Member

woodsp-ibm commented May 12, 2020

@stefan-woerner Yes, seems scikit-learn came out with a new version. #977 should fix this and once that's merged and the branch updated here this should then go through.

Should we have a test that exercises the aspect that was fixed by this PR? Normally if an issue is not picked up by tests we have added a test to ensure that aspect of the code is covered where presumably it was not before.

@woodsp-ibm woodsp-ibm merged commit aefba06 into qiskit-community:master May 14, 2020
@stefan-woerner stefan-woerner deleted the fix_recursive_optimization branch May 19, 2020 06:19
manoelmarques added a commit to qiskit-community/qiskit-optimization that referenced this pull request Jan 14, 2021
* fix recursive optimization

* Update recursive_minimum_eigen_optimizer.py

Co-authored-by: Manoel Marques <[email protected]>
Co-authored-by: Julien Gacon <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Random QiskitOptimizationError in quadratic program
4 participants