This repository was archived by the owner on Dec 7, 2021. It is now read-only.
Finance applications #1342
Merged
Finance applications #1342
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cryoris
requested review from
levbishop,
manoelmarques,
stefan-woerner and
woodsp-ibm
as code owners
Cryoris
added
the
status: on hold
… into finance-applications
Cryoris
commented
Oct 14, 2020
stefan-woerner
approved these changes
Oct 14, 2020
manoelmarques
approved these changes
Oct 14, 2020
woodsp-ibm
approved these changes
Oct 14, 2020
Cryoris
removed
the
status: on hold
Cryoris
added
the
Changelog: New Feature
manoelmarques
added a commit
to qiskit-community/qiskit-finance
that referenced
this pull request
Jan 19, 2021
* add GCI * add FIEV circuit * add ECD * add ECEV (Todo left) * move, renaming * append as gates not instr * add basic tests * add more tests, update readme sample * add reno * fix CI * update spelling dict * Update README.md Co-authored-by: Manoel Marques <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Blocked on Qiskit/qiskit#5068, CI breaks because it uses the circuits introduced in that PR.Closes #1327.
Details and comments
Ports the finance-specific
CircuitFactoryobjects toQuantumCircuits and move them tofinance/applications.Most of the tutorials are already rewritten, the corresponding PR will be opened after this is merged.
The old objects will be deprecated in a next step with the circuit factory.