This repository was archived by the owner on Dec 7, 2021. It is now read-only.
Make QGAN run primarily on circuits #1341
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cryoris
requested review from
levbishop,
manoelmarques,
pbark,
stefan-woerner and
woodsp-ibm
as code owners
Cryoris
added
Changelog: Deprecation
Zoufalc
approved these changes
Oct 13, 2020
manoelmarques
approved these changes
Oct 13, 2020
manoelmarques
added a commit
to qiskit-community/qiskit-machine-learning
that referenced
this pull request
Feb 27, 2021
* make quantum generator use circuits primarily * add test and deprecation warning * add reno * fix lint Co-authored-by: Manoel Marques <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Instead of passing
Uni/MultivariateVariationalDistributions to theQuantumGeneratorin the QGAN algorithms -- which are just wrappers for quantum circuits -- support passing circuit directly and deprecate these wrapper classes as inputs.Details and comments
Part of the deprecation of the circuit factory. In a next step, the
Uni/MultivariateDistributions are removed from the tutorials and then deprecated.