This repository was archived by the owner on Dec 7, 2021. It is now read-only.
Fix Exchange/Wiki providers, new Yahoo! provider, fix divide by 0 #1051
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manoelmarques
changed the title
manoelmarques
force-pushed
the
provider
branch
2 times, most recently
from
52b95c6 to
198c9f8
Compare
manoelmarques
changed the title
manoelmarques
force-pushed
the
provider
branch
3 times, most recently
from
c2be44e to
0db4d5b
Compare
manoelmarques
changed the title
manoelmarques
force-pushed
the
provider
branch
2 times, most recently
from
b9c903b to
831aa36
Compare
|
Should we make all these data provider installs optional? 🤔 |
woodsp-ibm
approved these changes
Jun 24, 2020
dlyongemallo
pushed a commit
to dlyongemallo/qiskit-aqua
that referenced
this pull request
Jul 15, 2020
…skit-community#1051) * Fix Exchange/wiki providers, new Yahoo! provider, fix divide by 0 * add words to pylintdic to support latest pyenchant on mac * Remove unused stockmarket parameter * handle division by 0 * make pandas, quandl, yfinance optional * fix spelling * install pandas,quandl,yfinance on aqua install * expand not installed msgs
pbark
pushed a commit
to pbark/qiskit-aqua
that referenced
this pull request
Sep 16, 2020
…skit-community#1051) * Fix Exchange/wiki providers, new Yahoo! provider, fix divide by 0 * add words to pylintdic to support latest pyenchant on mac * Remove unused stockmarket parameter * handle division by 0 * make pandas, quandl, yfinance optional * fix spelling * install pandas,quandl,yfinance on aqua install * expand not installed msgs
manoelmarques
added a commit
to qiskit-community/qiskit-finance
that referenced
this pull request
Jan 19, 2021
…skit-community/qiskit-aqua#1051) * Fix Exchange/wiki providers, new Yahoo! provider, fix divide by 0 * add words to pylintdic to support latest pyenchant on mac * Remove unused stockmarket parameter * handle division by 0 * make pandas, quandl, yfinance optional * fix spelling * install pandas,quandl,yfinance on aqua install * expand not installed msgs
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #775
Fixes #781
Fixes #1066
Details and comments
Fixed access to Quandl. Improved error handling and unit testing. Wiki data is legacy in Quandl but that legacy data still works on the provider.
I updated the tutorial at: https://github.com/manoelmarques/qiskit-tutorials/blob/aqua0.7/legacy_tutorials/aqua/finance/data_providers/time_series.ipynb