feat(3d/renderview): extract ambient occlusion renderview #61626
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benoitdm-oslandia
force-pushed
the
feat/ao_renderview
branch
from
91d204f to
90c911a
Compare
🪟 Windows Qt6 buildsDownload Windows Qt6 builds of this PR for testing. 🪟 Windows buildsDownload Windows builds of this PR for testing. |
wonder-sk
reviewed
May 7, 2025
wonder-sk
approved these changes
May 16, 2025
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is part of qgis/QGIS-Enhancement-Proposals#259 QEP (relates to qgis/QGIS-Enhancement-Proposals#252) and follows #60159.
It extracts the ambient occlusion render view into a dedicated class.
More PR will follow with the others renderviews.
cc @ptitjano @mkrus
Funded by CEA/DAM @renardf