fix(gcp): prevent crash for missing record #846

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

qdm12 merged 1 commit into qdm12:master from mcfedr:patch-1

Oct 22, 2024

Contributor

mcfedr commented Oct 21, 2024

Currently if the record is missing from GCP updater will crash with a null pointer at for _, rrdata := range recordResourceSet.Rrdatas {

so this moves the case when its null first and prevents the crash


          fix(gcp): prevent crash for missing record

c24ad0c

qdm12 approved these changes

View reviewed changes

Owner

qdm12 left a comment

Thanks for the fix!!! 🎖️

qdm12 merged commit bb231bc into qdm12:master

5 checks passed

qdm12 pushed a commit that referenced this pull request


          fix(gcp): prevent crash for missing record (#846)

4c7f17e

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet