Provider Porkbun: Remove trailing '.' from alias delete request #775
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
\# Description The porkbun documentation example request to delete a domain does not contain a trailing '.' `URI Endpoint Example: https://api.porkbun.com/api/json/v3/dns/deleteByNameType/borseth.ink/A/www` This updates the code to match that. \# Test-Plan Changed delete to allow arbitrary deletes of any type (instead of just ALIAS) Changed code to delete+create instead of update to change a porkbun domain Verified that delete works by deleting and creating a domain to update it instead of calling the update endpoint.
qdm12
approved these changes
Jul 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The porkbun documentation example request to delete a domain does not contain a trailing '.'
URI Endpoint Example: https://api.porkbun.com/api/json/v3/dns/deleteByNameType/borseth.ink/A/wwwThis updates the code to match that.
Test-Plan
Changed delete to allow arbitrary deletes of any type (instead of just ALIAS)
Changed code to delete+create instead of update to change a porkbun domain Verified that delete works by deleting and creating a domain to update it instead of calling the update endpoint.