Skip to content

Feat: add servercow provider #224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 9, 2021
Merged

Conversation

baswag
Copy link
Contributor

@baswag baswag commented Jul 31, 2021

No description provided.

Copy link
Owner

@qdm12 qdm12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!!

A few small changes that have to be fixed before I can merge that as follow.

var parsedJSON struct {
Message string `json:"message"`
Error string `json:"error"`
}
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

Copy link
Owner

@qdm12 qdm12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice thanks for the modifications and fixes! Just one tiny more fix that makes the CI fail and we can merge this!

Co-authored-by: Quentin McGaw <[email protected]>
@qdm12 qdm12 merged commit e735ef3 into qdm12:master Aug 9, 2021
@qdm12
Copy link
Owner

qdm12 commented Aug 9, 2021

Nice thanks, it's merged now. I pushed that tiny a4af81d commit so that the lint stage passes as there 2 more linting errors. It should now be incorporated in the :latest image. I'll do a release image tag sometime soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants