-
-
Notifications
You must be signed in to change notification settings - Fork 205
Feat: add servercow provider #224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution!!
A few small changes that have to be fixed before I can merge that as follow.
var parsedJSON struct { | ||
Message string `json:"message"` | ||
Error string `json:"error"` | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice thanks for the modifications and fixes! Just one tiny more fix that makes the CI fail and we can merge this!
Co-authored-by: Quentin McGaw <[email protected]>
Nice thanks, it's merged now. I pushed that tiny a4af81d commit so that the lint stage passes as there 2 more linting errors. It should now be incorporated in the |
No description provided.