[WebUI]: Print error messages upon receiving invalid header fields

[Chocobo1]

Due to #7577, some error message is needed to ease the diagnosis pain.

ps. I'll be moving isCrossSiteRequest out of this class later, thus I need to pass env as a parameter.

[glassez]

Didn't pay attention before...
These two methods have incorrect design. There is no need to pass class members as parameters of non-static class methods. You can use request_ and env_ inside it directly.

[Chocobo1]

You missed my ps. in the first post.
As you can see isCrossSiteRequest() depends solely on Http::Request members and the addition of Http::Environment/QHostAdress is purely for debug message use.
I plan to move this method under Http::Request class, thus I still need Http::Environment or QHostAdress in the future.

BTW, I see no reason why there are 2 separate classes: Http::Request Http::Environment, IMO they should be merged together, but that is for later.

[glassez]

BTW, I see no reason why there are 2 separate classes:

The main reason is Environment contains data that is not part of request itself (client address is not even part of HTTP protocol).

[Chocobo1]

The main reason is Environment contains data that is not part of request itself (client address is not even part of HTTP protocol).

I understand your point now, yet I think for coding convenience, there should be a super set containing the 2 structs (just an idea)

---

You missed my ps. in the first post.

What do you think? or I should use class members now and refactor later?

[glassez]

or I should use class members now and refactor later?

Yes.

[Chocobo1]

You can use request_ and env_ inside it directly.

OK, done.

[glassez]

But you still pass request as parameter...

[glassez]

If you don't want to fix existing code then ok, will do it later.

[Chocobo1]

I would like to minimize the changes now.

[glassez]

I plan to move this method under Http::Request class

Now it just a structure of some parsed data. I wouldn't change this behavior. It is created only once (when we parse http request data) and it shouldn't be modified later. So you can add some extra field into it (e.g. isCrossSite) and fill it when you parse.

[Chocobo1]

Thanks!