Skip to content

Chatroom features #669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

Anushkaagrawal22
Copy link
Contributor

πŸ“Œ Summary
This PR introduces location sharing and message reactions to enhance user engagement. Users can now send their current location in chat and react to messages with emojis.

πŸ›  Changes Made
βœ… Added Location Sharing:
βœ… Integrated geolocator for fetching user location.
βœ… Implemented UI button for sending location.
βœ… Handled location permissions.
βœ… Added Reactions Feature:
βœ… Added emoji picker for selecting reactions.

πŸš€ How to Test
1️⃣ Location Sharing:
Navigate to chat.
Click the πŸ“ Location button and allow permissions.
Verify that the location is sent and displayed correctly.
Send location by clicking on the button present at top

2️⃣ Reactions:
Select an emoji reaction.
Confirm the reaction updates in real-time.

βœ… Final Notes
This update improves user interaction and lays the groundwork for future enhancements like live location sharing and custom emoji reactions. Let me know if any changes are needed! πŸš€

Screenshots (if applicable):
image

image

#489

@MathJud
Copy link
Member

MathJud commented Apr 1, 2025

Dear @Anushkaagrawal22 thanks a lot for the PR.
While testing it I discovered the following things, that IMHO need further discussion and development.

Emoticon Selection

  • it's a nice way to select emoticons, and a good option to offer this.
  • The emoticons on my Linux laptop look differently thought then the emoticons that I selected.
  • I don't know whether an emoticon should be sent directly after selecting one.
  • we are planning to have emoticon reactions to messages, that should be displayed with the message directly. This needs further integration with the messaging protocol first though.

Send location

Location display is not working on Linux, on Android it is loaded correctly from Google maps, as the screenshot suggests.

As an off-the-grid messenger we would not be depending on online content.
My suggestion to tackle this problem would be the following:

A) send a geo URI scheme encoded location that can be opened in another app

  • to send location
    • have geo sharings on mobile platforms to send a location.
    • get location information from the system, convert and send it directly as a geo:// link
  • to display the received location:
    • open the link in a maps app (at least on mobile)
    • find a solution for desktop applications
      B) distribute vector tile maps within the app. This needs some base work first:
  • have a vector tile download and sharing mechanism
    • have a public file sharing mechanism within qaul
  • display vector tiles within the app

@Anushkaagrawal22
Copy link
Contributor Author

Ok sir, I will make changes in the pr as you suggested.

@Anushkaagrawal22
Copy link
Contributor Author

Anushkaagrawal22 commented Apr 3, 2025

  • The emoticons on my Linux laptop look differently thought then the emoticons that I selected.

I am trying to resolve this issue

  • I don't know whether an emoticon should be sent directly after selecting one.

I have updated the pr as per your input
image

Send location

A) send a geo:// location that can be opened in another app

  • to send location

    • have geo sharings on mobile platforms to send a location.
    • get location information from the system, convert and send it directly as a geo:// link
  • to display the received location:

    • open the link in a maps app (at least on mobile)
    • find a solution for desktop applications

I have also resolved this issue now when you'll click on the link it will tell you to choose using which app you want to open the link from there you can open it
image

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants