Skip to content

Catching music panics, disabling cache in CLI ... #1466

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Mar 13, 2025
Merged

Conversation

qarmin
Copy link
Owner

@qarmin qarmin commented Mar 11, 2025

  • catch panics when reading broken files in symphonia
  • ability to disable cache in CLI
  • added benchmarks scripts
  • renamed CONFIG/CACHE_PATH to CZKAWKA_CONFIG/CZKAWKA_CACHE_PATH

@qarmin qarmin requested a review from Copilot March 12, 2025 21:19
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR improves error handling by catching panics when processing broken files and adds the ability to disable cache via CLI while updating configuration environment variable names. Key changes include:

  • Updating error reporting in several modules by replacing println! with error! logging.
  • Changing environment variable names from CONFIG_PATH/CACHE_PATH to CZKAWKA_CONFIG_PATH/CZKAWKA_CACHE_PATH.
  • Adding a new flag in the CLI to disable caching and minor updates in CI workflows and dependency versions.

Reviewed Changes

Copilot reviewed 18 out of 18 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
czkawka_core/src/tools/same_music.rs Enhances panic handling for file reading by logging errors instead of printing.
czkawka_core/src/common.rs Updates environment variable names and filtering mechanism.
czkawka_core/src/common_image.rs Replaces println with error logging for image processing crashes.
czkawka_core/src/tools/broken_files.rs Replaces println with error logging for handling broken files.
Changelog.md Updates release notes to reflect breaking changes and new features.
.github/workflows/linux.yml Adjusts build and artifact naming details in Linux CI workflows.
czkawka_core/build.rs Adds logging for CARGO_ENCODED_RUSTFLAGS; note potential typo in env var name.
czkawka_cli/src/main.rs Sets cache usage based on the new disable_cache CLI flag.
Cargo.toml Updates resolver version from 2 to 3.
instructions/Instruction.md Updates documentation for the new environment variable names.
czkawka_core/Cargo.toml Upgrades handsome_logger dependency from 0.8 to 0.9.
czkawka_cli/src/commands.rs Introduces a new CLI flag to disable caching.

@qarmin qarmin merged commit 60dae5a into master Mar 13, 2025
32 checks passed
@qarmin qarmin deleted the fix-calculation-hash branch March 13, 2025 05:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant