Persistent group titles get mixed up

[anthonybilinski]

Brief Description

OS: Ubuntu 18.04
qTox version: v1.16.3+
Commit hash: aa83edf
toxcore: v0.2.8
Qt: 5.9.5
Hardware: Desktop

Reproducible: Almost Always

Steps to reproduce

1. Save multiple groups with different names using persistent groups.
2. Restart qTox.

Observed Behavior

1. Groups have correct names when you are the only member in them.
2. As you reconnect to more peers in the group, one of the groups gets the name of one of your other groups.
3. Restarting qTox again has the correct group names again (not the ones that were last displayed).

Expected Behavior

1. Group names are never mixed.

Additional Info

Seems to be new behaviour, never saw this on ea9f429

[anthonybilinski]

It looks like this may be a toxcore bug. Reproduction is ~1/20 starts with 4 groups. I see:

[05:28:26.833 UTC] core/core.cpp:1053 : Debug: core, adding group with name "group A"
[05:28:26.833 UTC] core/core.cpp:1053 : Debug: core, adding group with name "group B"
[05:28:26.833 UTC] core/core.cpp:1053 : Debug: core, adding group with name "group C"
[05:28:26.833 UTC] core/core.cpp:1053 : Debug: core, adding group with name "group D"
...
[05:28:57.997 UTC] core/core.cpp:508 : Debug: "Group 3 peerlist changed"
[05:29:06.449 UTC] core/core.cpp:508 : Debug: "Group 1 peerlist changed"
[05:29:06.599 UTC] core/core.cpp:508 : Debug: "Group 2 peerlist changed"
[05:29:06.605 UTC] core/coreav.cpp:576 : Debug: "Leaving group call 2"
[05:29:06.899 UTC] core/core.cpp:508 : Debug: "Group 2 peerlist changed"
[05:29:06.907 UTC] core/coreav.cpp:576 : Debug: "Leaving group call 2"
[05:29:07.298 UTC] core/core.cpp:508 : Debug: "Group 2 peerlist changed"
[05:29:07.308 UTC] core/coreav.cpp:576 : Debug: "Leaving group call 2"
[05:29:07.350 UTC] core/core.cpp:1103 : Critical: Peer not found
[05:29:07.350 UTC] core/core.cpp:525 : Debug: Core::onGroupTitleChange by "" to "group C"
[05:29:07.350 UTC] model/group.cpp:67 : Debug: Group::setTitle by "" from "group A" to "group C"

Group A in this case is an empty group with just myself in it. onGroupTitleChange is only called by tox_callback_conference_title from toxcore, and the Critical: Peer not found comes from TOX_ERR_CONFERENCE_PEER_QUERY_PEER_NOT_FOUND when we try to lookup the peer number with the group given by the callback.

It seems to consistently happen with only "group A" so there's likely something special about Group 0. This group used to have other members in it before, so toxcore's view of persistent members may still have state of them.

I'm pretty sure I'm running toxcore dd539800eea8cfc70d6cb14a7fd0ddefb2082cd1 from TokTok/c-toxcore#1267, but can't see a way to verify that.

I'll open an issue upstream and see what the toxcore guys think about this.

[anthonybilinski]

Should be fixed by TokTok/c-toxcore#1287.