Add libwebp to contributing doc #9119
Open
+3
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
libwebp
to the contributing doc. Previously, it was not there and if you followed the default instructions, the webp tests would fail.Note that libwebp pulls in standard jpeg, so we end up having both
jpeg
andlibjpeg-turbo
installed. All tests pass in my Linux environment, though, so I assume we're usinglibjpeg-turbo
at runtime. It's worth noting what we do for CI. On Linux, we install both much the same as what I'm putting in our contributing doc:vision/packaging/pre_build_script.sh
Lines 36 to 37 in 7b283c2
But on Mac, we do this dance:
vision/packaging/pre_build_script.sh
Lines 16 to 21 in 7b283c2
I bring this up because our Mac contributors might run into the above.