Skip to content

Add libwebp to contributing doc #9119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

scotts
Copy link
Contributor

@scotts scotts commented Jun 23, 2025

Adds libwebp to the contributing doc. Previously, it was not there and if you followed the default instructions, the webp tests would fail.

Note that libwebp pulls in standard jpeg, so we end up having both jpeg and libjpeg-turbo installed. All tests pass in my Linux environment, though, so I assume we're using libjpeg-turbo at runtime. It's worth noting what we do for CI. On Linux, we install both much the same as what I'm putting in our contributing doc:

conda install libwebp -y
conda install libjpeg-turbo -c pytorch

But on Mac, we do this dance:
conda install libpng libwebp -y
# Installing webp also installs a non-turbo jpeg, so we uninstall jpeg stuff
# before re-installing them
conda uninstall libjpeg-turbo libjpeg -y
conda install -y ffmpeg=4.2 -c pytorch
conda install -y libjpeg-turbo -c pytorch

I bring this up because our Mac contributors might run into the above.

Copy link

pytorch-bot bot commented Jun 23, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/9119

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 3 Unrelated Failures

As of commit 6bb8f8b with merge base 7b283c2 (image):

NEW FAILURE - The following job has failed:

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants