Skip to content

Cleanup in get_enum_from_fn #8852

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 19, 2025

Conversation

GdoongMathew
Copy link
Contributor

fix #8847

Copy link

pytorch-bot bot commented Jan 13, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/8852

Note: Links to docs will display an error until the docs builds have been completed.

❌ 16 New Failures, 5 Pending, 13 Unrelated Failures

As of commit 82499ac with merge base 8bed9d8 (image):

NEW FAILURES - The following jobs have failed:

FLAKY - The following job failed but was likely due to flakiness present on trunk:

BROKEN TRUNK - The following jobs failed but was present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@GdoongMathew
Copy link
Contributor Author

I think these failed unittests were not caused by this PR.

@GdoongMathew GdoongMathew force-pushed the refactor/get_enum_from_fn branch from 73db4d4 to 085c7fd Compare February 12, 2025 15:05
@GdoongMathew
Copy link
Contributor Author

A friendly ping to @NicolasHug for a review~

Copy link
Member

@NicolasHug NicolasHug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @GdoongMathew

@NicolasHug NicolasHug merged commit b5c7443 into pytorch:main Feb 19, 2025
27 of 62 checks passed
@GdoongMathew GdoongMathew deleted the refactor/get_enum_from_fn branch February 19, 2025 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cleanup _get_enum_from_fn implementation in _api.py
3 participants