Skip to content

bump version to remove old prerelease status #8431

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 20, 2024

Conversation

ConnorBaker
Copy link

Hello!

The version in version.txt doesn't match the version in the tag for your 0.18.0 release (0.18.0a0 vs 0.18.0). Additionally, because the version included a0 in the patch component, tools like packaging (https://github.com/pypa/packaging) flagged the release as a prerelease. I believe this was a mistake given the version.txt for previous non-rc tags don't use this scheme.

Since you've already made a 0.18.0 release (though the version.txt inside doesn't match), I felt it made the most sense to bump the patch component to allow for a new release.

Copy link

pytorch-bot bot commented May 19, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/8431

Note: Links to docs will display an error until the docs builds have been completed.

❌ 12 New Failures, 2 Unrelated Failures

As of commit 97e3fa9 with merge base 9cb639a (image):

NEW FAILURES - The following jobs have failed:

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

Copy link
Member

@NicolasHug NicolasHug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for pointing out this mismatch @ConnorBaker. This should actually be 0.19.0a0 as this is the pre-release of 0.19.0. I've made the changes in this PR

EDIT Oh, I didn't realize this PR is made against the release/0.18 branch. I've updated the version to 0.18.1.a0.

@NicolasHug NicolasHug merged commit 126fc22 into pytorch:release/0.18 May 20, 2024
45 of 60 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants