Skip to content

Fix for use download_and_extract in SBU dataset (#7046) #7051

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 21, 2022
Merged

Fix for use download_and_extract in SBU dataset (#7046) #7051

merged 2 commits into from
Dec 21, 2022

Conversation

deepsghimire
Copy link
Contributor

@deepsghimire deepsghimire commented Dec 21, 2022 •
edited by pytorch-bot bot
Loading

Hi @pmeier please kindly review my PR for #7046

cc @pmeier

@facebook-github-bot
Copy link

Hi @deepsghimire!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

pmeier
pmeier approved these changes Dec 21, 2022
View reviewed changes
Copy link
Collaborator

@pmeier pmeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @deepsghimire! This should be good to merge if the relevant CI is green (some CI jobs are currently failing, but they are unrelated to this PR). But please note that you need to sign the CLA or otherwise we can't accept the contribution.

@pmeier pmeier linked an issue Dec 21, 2022 that may be closed by this pull request
Use download_and_extract in SBU dataset #7046
Closed
@deepsghimire
Copy link
Contributor Author

I signed the CLA right after my PR submission. I was notified that it takes time for changes to take effect.

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@pmeier pmeier merged commit 32d254b into pytorch:main Dec 21, 2022
@github-actions
Copy link

Hey @pmeier!

You merged this PR, but no labels were added. The list of valid labels is available at https://github.com/pytorch/vision/blob/main/.github/process_commit.py

@deepsghimire deepsghimire deleted the use-download-and-extract branch December 21, 2022 15:26
@deepsghimire deepsghimire restored the use-download-and-extract branch December 21, 2022 15:26
facebook-github-bot pushed a commit that referenced this pull request Jan 9, 2023
@facebook-github-bot
[fbsync] Fixes use download_and_extract in SBU dataset (#7046) (#7051)
743652d 
Reviewed By: NicolasHug

Differential Revision: D42414486

fbshipit-source-id: f445b51be419d527f012cffdece495f20e1fb7a1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmeier pmeier pmeier approved these changes

Assignees
No one assigned
Labels
cla signed enhancement module: datasets
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use download_and_extract in SBU dataset
3 participants
@deepsghimire @facebook-github-bot @pmeier