Add seeds on Kernel Info and reduce randomness for Gaussian Blur #6741
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
datumbox
changed the title
|
Thanks @datumbox , I rerun ubuntu test one more time to check. |
|
@vfdev-5 Yeah good call. I couldn't make the test fail locally at all. Tried every seed in [0,100] and also randomly sampled but nothing. I'm not 100% this resolves the issue, let's see what the rerun does. |
pmeier
pushed a commit
to pmeier/vision
that referenced
this pull request
Oct 12, 2022
…lur (pytorch#6741)" This reverts commit 6e72f2f.
This was referenced Oct 12, 2022
Merged
pmeier
added a commit
that referenced
this pull request
Oct 12, 2022
* Revert "Add seeds on Kernel Info and reduce randomness for Gaussian Blur (#6741)" This reverts commit 6e72f2f. * add fixture to fix the RNG seed * re-add changes to gaussian_blur_* sample input shapes Co-authored-by: Vasilis Vryniotis <[email protected]>
facebook-github-bot
pushed a commit
that referenced
this pull request
Oct 17, 2022
…Blur (#6741) Summary: * Add seeds on Kernel Info and reduce randomness for Gaussian Blur * Fix linter Reviewed By: NicolasHug Differential Revision: D40427486 fbshipit-source-id: 89c2310929084115d0537df369ec1a525c842d43
facebook-github-bot
pushed a commit
that referenced
this pull request
Oct 17, 2022
Summary: * Revert "Add seeds on Kernel Info and reduce randomness for Gaussian Blur (#6741)" This reverts commit 6e72f2f. * add fixture to fix the RNG seed * re-add changes to gaussian_blur_* sample input shapes Reviewed By: NicolasHug Differential Revision: D40427476 fbshipit-source-id: b0aae476915f2d4e58146edf8e9339338bd78ad5 Co-authored-by: Vasilis Vryniotis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to reduce the flakiness on the prototype
gaussian_blurkernel. This PR:KernelInfoobjects that can be set at the beginning of each test prior generating the data.