Add CREStereo weights. #6629
Merged
Add CREStereo weights. #6629
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Hi @TeodorPoncu , thanks for the PR! Could you give the command that you use to test and get those numbers on the PR description? (see #5793 for example)
YosuaMichael
approved these changes
Sep 23, 2022
There was a problem hiding this comment.
Thanks @TeodorPoncu , the PR looks good to me!
I have a minor NIT, but I will approve to unblock.
| "relepe": 0.114, | ||
| "fl-all": 90.429, | ||
| "_detailed": { | ||
| 1: { |
There was a problem hiding this comment.
NIT, lets give comment indicating that 1 is the number of cascade
…u/vision into add-crestereo-weights
|
Hey @TeodorPoncu! You merged this PR, but no labels were added. The list of valid labels is available at https://github.com/pytorch/vision/blob/main/.github/process_commit.py |
facebook-github-bot
pushed a commit
that referenced
this pull request
Sep 29, 2022
Summary: * added crestereo author weights * update weights name * synced fl-all metric * changed resize size config param name * extended weight sets * changed weight link Reviewed By: YosuaMichael Differential Revision: D39885429 fbshipit-source-id: 7d268ce2121101cb30b2aab5b99c70637182a2a1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes a CREStereo weight-template pointing towards the author provided weights and reference script trained weights.
Test commands are as following:
Reference base weights:
torchrun --nproc_per_node 1 --nnodes 1 cascade_evaluation.py --dataset middlebury2014-train --batch-size 1 --dataset-root $dataset_root --model crestereo_base --weights CREStereo_Base_Weights.CRESTEREO_ETH_MBL_V1will yield for 10 recursive iterations and 1 cascade:
'mae': 1.416, 'rmse': 3.53, '1px': 0.777, '3px': 0.896, '5px': 0.933, 'relepe': 0.148, 'fl-all': 78.388Reference finetuned weights:
torchrun --nproc_per_node 1 --nnodes 1 cascade_evaluation.py --dataset middlebury2014-train --batch-size 1 --dataset-root $dataset_root --model crestereo_base --weights CREStereo_Base_Weights.CRESTEREO_FINETUNE_MULTI_V1will yield for 10 recursive iterations and 1 cascade:
'mae': 1.02, 'rmse': 3.073, '1px': 0.854, '3px': 0.938, '5px': 0.96, 'relepe': 0.129, 'fl-all': 86.042Author weights:
torchrun --nproc_per_node 1 --nnodes 1 cascade_evaluation.py --dataset middlebury2014-train --batch-size 1 --dataset-root $dataset_root --model crestereo_base --weights CREStereo_Base_Weights.MEGVII_V1will yield for recursive iterations and 1 cascade:
'mae': 0.792, 'rmse': 2.765, '1px': 0.905, '3px': 0.958, '5px': 0.97, 'relepe': 0.114, 'fl-all': 90.429