Skip to content

Update third_party dependencies #2295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

alexreinking
Copy link

Newer versions of CMake (>=4.0) have dropped backwards compatibility with older versions of CMake (<3.5). All of double-conversion, sentencepiece, and utf8proc point to commits that declare minimum CMake versions older than that, breaking the build. Fortunately, the minimum CMake versions have all been bumped upstream, and just updating the submodules seems to work.

Fixes #2294

Newer versions of CMake (>=4.0) have dropped backwards compatibility
with older versions of CMake (<3.5). All of double-conversion,
sentencepiece, and utf8proc point to commits that declare minimum
CMake versions older than that, breaking the build. Fortunately,
the minimum CMake versions have all been bumped upstream, and just
updating the submodules seems to work.

Fixes pytorch#2294
Copy link

pytorch-bot bot commented Jul 12, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/text/2295

Note: Links to docs will display an error until the docs builds have been completed.

❌ 9 New Failures, 3 Cancelled Jobs, 3 Unrelated Failures

As of commit 28ccf3c with merge base bde7ecd (image):

NEW FAILURES - The following jobs have failed:

CANCELLED JOBS - The following jobs were cancelled. Please retry:

FLAKY - The following job failed but was likely due to flakiness present on trunk:

BROKEN TRUNK - The following jobs failed but was present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot
Copy link
Contributor

Hi @alexreinking!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

torchtext no longer builds with CMake >=4.0
3 participants