-
Notifications
You must be signed in to change notification settings - Fork 814
Update third_party dependencies #2295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Newer versions of CMake (>=4.0) have dropped backwards compatibility with older versions of CMake (<3.5). All of double-conversion, sentencepiece, and utf8proc point to commits that declare minimum CMake versions older than that, breaking the build. Fortunately, the minimum CMake versions have all been bumped upstream, and just updating the submodules seems to work. Fixes pytorch#2294
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/text/2295
Note: Links to docs will display an error until the docs builds have been completed. ❌ 9 New Failures, 3 Cancelled Jobs, 3 Unrelated FailuresAs of commit 28ccf3c with merge base bde7ecd ( NEW FAILURES - The following jobs have failed:
CANCELLED JOBS - The following jobs were cancelled. Please retry:
FLAKY - The following job failed but was likely due to flakiness present on trunk:
BROKEN TRUNK - The following jobs failed but was present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Hi @alexreinking! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
Newer versions of CMake (>=4.0) have dropped backwards compatibility with older versions of CMake (<3.5). All of double-conversion, sentencepiece, and utf8proc point to commits that declare minimum CMake versions older than that, breaking the build. Fortunately, the minimum CMake versions have all been bumped upstream, and just updating the submodules seems to work.
Fixes #2294