Skip to content

ci: Add generic windows_job #887

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 15 commits into from
Oct 18, 2022
Merged

ci: Add generic windows_job #887

merged 15 commits into from
Oct 18, 2022

Conversation

seemethere
Copy link
Member

@seemethere seemethere commented Oct 14, 2022 •
edited
Loading

Adds a generic windows job that's similar to our generic linux job (#783)

Usage would be like:

name: Test build/test windows cpu

on:
  pull_request:
  push:
    branches:
      - main

jobs:
  build-test:
    uses: pytorch/test-infra/.github/workflows/windows_job.yml@main
    with:
      script: |
        pip install -r requirements.txt
        python setup.py develop
        pytest tests/

Signed-off-by: Eli Uriegas [email protected]

@vercel
Copy link

vercel bot commented Oct 14, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
torchci ⬜️ Ignored (Inspect) Oct 18, 2022 at 5:01PM (UTC)

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 14, 2022
@seemethere seemethere marked this pull request as ready for review October 17, 2022 20:51
@seemethere seemethere requested a review from a team October 17, 2022 20:51
@seemethere
ci: Add generic windows_job
89585da 
Adds a generic windows job that's similar to our generic linux job

Signed-off-by: Eli Uriegas <[email protected]>
@seemethere
fix typo, switch to bash.exe
d2d724a 
Signed-off-by: Eli Uriegas <[email protected]>
@seemethere
switch to powershell
698a47a 
Signed-off-by: Eli Uriegas <[email protected]>
@seemethere
switch back to bash, output script into temp
f1ced4f 
Signed-off-by: Eli Uriegas <[email protected]>
@seemethere
use setup-miniconda
9eed527 
Signed-off-by: Eli Uriegas <[email protected]>
@seemethere
use existing miniconda installation
a9900d9 
Signed-off-by: Eli Uriegas <[email protected]>
@seemethere
just use bash
37f3328 
Signed-off-by: Eli Uriegas <[email protected]>
@seemethere
switch back to setup-miniconda
153f334 
Signed-off-by: Eli Uriegas <[email protected]>
@seemethere
specify path for environment to activate
5f69992 
Signed-off-by: Eli Uriegas <[email protected]>
@seemethere
add temp sleep
9e27920 
Signed-off-by: Eli Uriegas <[email protected]>
@seemethere
install pywin32==304, remove sleep
36f3d13 
Signed-off-by: Eli Uriegas <[email protected]>
@seemethere
python3 -> python
6dc1fe3 
Signed-off-by: Eli Uriegas <[email protected]>
@seemethere
add test for upload / download
06c29a2 
Signed-off-by: Eli Uriegas <[email protected]>
@seemethere seemethere force-pushed the seemethere/generic_windows_job.yml branch from fe85e2c to 06c29a2 Compare October 17, 2022 22:23
@seemethere seemethere added the Nova Tooling Tooling Related to Project Nova (CI Tooling) label Oct 18, 2022
atalman
atalman reviewed Oct 18, 2022
View reviewed changes
.github/workflows/test_windows_job.yml
test-infra-ref: ${{ github.ref }}
timeout: 60
script: |
conda create -y -n test python=3.8
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also include delete of conda environment at the end of the test ?

conda env remove -p test

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since these are ephemeral I'm not really too worried about it

atalman
atalman reviewed Oct 18, 2022
View reviewed changes
.github/workflows/test_windows_job.yml
conda activate test
python -m pip install --extra-index-url https://download.pytorch.org/whl/nightly/cpu --pre torch
# Can import pytorch
python -c 'import torch'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same think here, please include conda env remove

atalman
atalman approved these changes Oct 18, 2022
View reviewed changes
Copy link
Contributor

@atalman atalman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@seemethere seemethere merged commit 8897d6c into main Oct 18, 2022
@seemethere seemethere deleted the seemethere/generic_windows_job.yml branch October 18, 2022 20:33
@atalman atalman mentioned this pull request Nov 9, 2022
Merged
kit1980 pushed a commit that referenced this pull request Nov 23, 2022
@seemethere @kit1980
ci: Add generic windows_job (#887)
61489f0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atalman atalman atalman approved these changes

@osalpekar osalpekar osalpekar approved these changes

@kit1980 kit1980 Awaiting requested review from kit1980

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Nova Tooling Tooling Related to Project Nova (CI Tooling)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@seemethere @atalman @osalpekar @facebook-github-bot