Retry pr_time_benchmarks when it fails #6005
Conversation
|
@huydhn is attempting to deploy a commit to the Meta Open Source Team on Vercel. A member of the Team first needs to authorize it. |
facebook-github-bot
added
the
CLA Signed
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| if (job.name.toLocaleLowerCase().includes(flakyJobName)) { | ||
| return true; | ||
| } | ||
| } |
There was a problem hiding this comment.
I'm a bit confused as to what the intention is here? Specifically, why is it after all the other checks, is it just that this wants to rerun even if the test step failed?
There was a problem hiding this comment.
Yeah, I'm trying to make this job eligible for retry even if its test step fails. We don't retry that atm.
There was a problem hiding this comment.
In another word, if the job is pr_time_benchmarks job, it will always be retried one more time.
There was a problem hiding this comment.
I see. In that case maybe a list name like "ALWAYS_RETRY" would make more sense then, since KNOWN_FLAKY_JOBS makes me think that you know it's probably flaky so it's ok to never retry it. Doesn't really matter tho, since the comment explains
A request from @laithsakka, we want to retry this job in a different runner as it could fail flakily sometimes