Skip to content

gloo: fix error what #412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 26, 2025
Merged

gloo: fix error what #412

merged 1 commit into from
Feb 26, 2025

Conversation

d4l3k
Copy link
Member

@d4l3k d4l3k commented Feb 26, 2025

Summary:
This fixes the Gloo TCP transport error handling so errors don't accidentally get casted to Error which results in a no error message on connection errors.

terminate called after throwing an instance of 'std::runtime_error'
  what():  [fbcode/gloo/transport/tcp/pair.cc:147] no error

Differential Revision: D70212634

Summary:
This fixes the Gloo TCP transport error handling so errors don't accidentally get casted to `Error` which results in a `no error` message on connection errors.

```
terminate called after throwing an instance of 'std::runtime_error'
  what():  [fbcode/gloo/transport/tcp/pair.cc:147] no error
```

Differential Revision: D70212634
@facebook-github-bot
Copy link

This pull request was exported from Phabricator. Differential Revision: D70212634

@facebook-github-bot facebook-github-bot merged commit 5ca057d into main Feb 26, 2025
8 of 9 checks passed
@d4l3k d4l3k deleted the export-D70212634 branch February 26, 2025 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants