Skip to content

Add pypi cudnn package to tests #1168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 20, 2022
Merged

Add pypi cudnn package to tests #1168

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
af8c9f3
Add pypi cudnn package to tests
atalman Oct 20, 2022
0b46192
Fix pypi installation check
atalman Oct 20, 2022
559deba
Fix pypi instructions setting
atalman Oct 20, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions .github/actions/validate-binary/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,10 @@ inputs:
description: 'Installation instructions'
required: true
default: ''
installation_pypi:
description: 'Installation instructions for pypi'
required: false
default: ''
python_version:
description: 'Python version'
required: true
Expand Down Expand Up @@ -60,13 +64,16 @@ runs:
GPU_ARCH_VER: ${{ inputs.gpu_arch_ver }}
GPU_ARCH_TYPE: ${{ inputs.gpu_arch_type }}
INSTALLATION: ${{ inputs.installation }}
INSTALLATION_PYPI: ${{ inputs.installation_pypi }}
ENV_NAME: conda-env-${{ github.run_id }}
DESIRED_PYTHON: ${{ inputs.python_version }}
DESIRED_CUDA: ${{ inputs.desired_cuda }}
DESIRED_DEVTOOLSET: ${{ inputs.dev_toolset }}
PACKAGE_TYPE: ${{ inputs.package_type }}
TARGET_OS: ${{ inputs.target_os }}
run: |

# Special case Python 3.11 wheels
if [ $DESIRED_PYTHON == '3.11' ]; then
set -ex
export CPYTHON_VERSIONS=3.11.0
Expand All @@ -84,6 +91,15 @@ runs:
eval ${PYTHON_PATH}/python ./test/smoke_test/smoke_test.py --package torchonly
else
set -ex

# Special case Pypi installation instructions
if [ ! -z $INSTALLATION_PYPI ]; then
conda create -yp ${ENV_NAME}_pypi python=${{ inputs.python_version }} numpy
conda run -p ${ENV_NAME}_pypi $INSTALLATION
conda run -p ${ENV_NAME}_pypi python3 ./test/smoke_test/smoke_test.py --package torchonly
conda env remove -p ${ENV_NAME}_pypi
fi

conda create -yp ${ENV_NAME} python=${{ inputs.python_version }} numpy
conda run -p ${ENV_NAME} $INSTALLATION
conda run -p ${ENV_NAME} python3 ./test/smoke_test/smoke_test.py
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/validate-linux-binaries.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,7 @@ jobs:
gpu_arch_type: ${{ matrix.gpu_arch_type }}
gpu_arch_ver: ${{ matrix.gpu_arch_version }}
installation: ${{ matrix.installation }}
installation_pypi: ${{ matrix.installation_pypi }}
python_version: ${{ matrix.python_version }}
desired_cuda: ${{ matrix.desired_cuda }}
dev_toolset: ''
Expand Down