Publish/unpublish petition from edition page #257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lpoujade
changed the title
fallen
requested changes
Oct 2, 2020
lpoujade
force-pushed
the
196_publish_petition_from_edition
branch
from
1d0f704 to
85341f8
Compare
|
Hello @lpoujade , I hope you are well :) |
|
Hi, thank for the reminder ! I do this :) |
Use petition id instead of random number Remove alert div if retry was successful
|
Is it ok like this or did i have to add tests or something ? |
fallen
approved these changes
Sep 24, 2021
|
Awesome! Thanks for the changes :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For issue #196, plus js to add an alert in case of failure (both on edition page and in dashboard)