Skip to content

Improve asyncio.subprocess stubs #5327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
May 3, 2021

Conversation

JelleZijlstra
Copy link
Member

  • Remove comments about typevars becoming types with typevars doesn't work mypy#1236, the issue has been closed, and I don't think using TypeVars would actually help here
  • Instead of **kwds: Any, track down the actual keyword args these functions take. On both Unix and Windows it ultimately delegates to subprocess.Popen.

@github-actions
Copy link
Contributor

github-actions bot commented May 3, 2021

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

@github-actions
Copy link
Contributor

github-actions bot commented May 3, 2021

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

@github-actions
Copy link
Contributor

github-actions bot commented May 3, 2021

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

1 similar comment
@github-actions
Copy link
Contributor

github-actions bot commented May 3, 2021

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

@hauntsaninja hauntsaninja merged commit 38dfb57 into python:master May 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants