Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Authlib #13801

Merged
merged 2 commits into from
Apr 7, 2025
Merged

Improve Authlib #13801

merged 2 commits into from
Apr 7, 2025

Conversation

donBarbos
Copy link
Contributor

  • Define consts and utility functions

@donBarbos
Improve Authlib
009891e 
* Define consts and utility functions
@donBarbos
Copy link
Contributor Author

donBarbos commented Apr 5, 2025 •
edited
Loading

to be honest I couldn't understand why the error occurs since we have a similar import style in authlib.oidc.core

EDIT: maybe someone could tell me why this is happening :)

@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@srittau
Copy link
Collaborator

srittau commented Apr 7, 2025 •
edited
Loading

authlib.oicd.registration simply doesn't exist in Authlib 1.4.*, which our stubs currently support. #13540 – which updates Authlib to 1.5.* – is currently waiting for review.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 7, 2025

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

@srittau srittau merged commit e26a15f into python:main Apr 7, 2025
43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srittau srittau srittau approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@donBarbos @srittau