[auth0-python] Add async functions to AsyncAuth0 #13799
Open
+62
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
srittau
reviewed
Apr 7, 2025
Comment on lines
5
to
+38
| from auth0.rest import RestClientOptions as RestClientOptions | ||
|
|
||
| from ..asyncify import asyncify as asyncify | ||
| from .actions import Actions as Actions | ||
| from .attack_protection import AttackProtection as AttackProtection | ||
| from .auth0 import Auth0 as Auth0 | ||
| from .blacklists import Blacklists as Blacklists | ||
| from .branding import Branding as Branding | ||
| from .client_credentials import ClientCredentials as ClientCredentials | ||
| from .client_grants import ClientGrants as ClientGrants | ||
| from .clients import Clients as Clients | ||
| from .connections import Connections as Connections | ||
| from .custom_domains import CustomDomains as CustomDomains | ||
| from .device_credentials import DeviceCredentials as DeviceCredentials | ||
| from .email_templates import EmailTemplates as EmailTemplates | ||
| from .emails import Emails as Emails | ||
| from .grants import Grants as Grants | ||
| from .guardian import Guardian as Guardian | ||
| from .hooks import Hooks as Hooks | ||
| from .jobs import Jobs as Jobs | ||
| from .log_streams import LogStreams as LogStreams | ||
| from .logs import Logs as Logs | ||
| from .organizations import Organizations as Organizations | ||
| from .prompts import Prompts as Prompts | ||
| from .resource_servers import ResourceServers as ResourceServers | ||
| from .roles import Roles as Roles | ||
| from .rules import Rules as Rules | ||
| from .rules_configs import RulesConfigs as RulesConfigs | ||
| from .stats import Stats as Stats | ||
| from .tenants import Tenants as Tenants | ||
| from .tickets import Tickets as Tickets | ||
| from .user_blocks import UserBlocks as UserBlocks | ||
| from .users import Users as Users | ||
| from .users_by_email import UsersByEmail as UsersByEmail |
There was a problem hiding this comment.
I just noticed that these are all re-exported from this file. I don't think we should do that and just use normal import for the items we need in this file (I.e. just from .tenants import Tenants without the as Tenants part.) This applies to all imports, not just the new ones.
There was a problem hiding this comment.
What I found with this is that my IDE considers these unused if I remove the as import - should I ignore that?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add async functions to AyncAuth0 class.