New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small improvement of `ts_utils.get_gitignore_spec` #13797

Merged

srittau merged 1 commit into python:main from Avasam:small-improvement-of-ts_utils.get_gitignore_spec

Apr 7, 2025

Collaborator

Avasam commented Apr 4, 2025

#13795 (comment)

There is a specialized class, pathspec.GitIgnoreSpec, which more closely
implements the behavior of gitignore. This uses GitWildMatchPattern
pattern by default and handles some edge cases differently from the generic
PathSpec class. GitIgnoreSpec can be used without specifying the pattern
factory::

spec = pathspec.GitIgnoreSpec.from_lines(spec_text.splitlines())

#13795 (comment)

Could also omit the call to .readlines(). GitIgnoreSpec.from_lines takes an iterable of lines, so passing the file i/o object directly would work. Not sure if there's any reason to prefer one way or another, though


          Small improvement of ts_utils.get_gitignore_spec

02c9c64

Avasam mentioned this pull request

Enable Ruff flake8-use-pathlib (PTH) #13795

Draft

srittau approved these changes

View reviewed changes

srittau merged commit 09416d0 into python:main

40 checks passed

Avasam deleted the small-improvement-of-ts_utils.get_gitignore_spec branch

April 7, 2025 15:44

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet