Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove incorrect CSS property #178

Merged
merged 1 commit into from
Mar 17, 2024
Merged

Remove incorrect CSS property #178

merged 1 commit into from
Mar 17, 2024

Conversation

Privat33r-dev
Copy link
Contributor

No description provided.

@hugovk
Copy link
Member

hugovk commented Mar 17, 2024

Yes, we should fix this :)

But should we fix it by removing text-size, and not reducing the font size? So essentially maintain the status quo? I think I prefer the bigger ">>>" button:

Status quo: not setting font-size

image

https://python-docs-theme-previews.readthedocs.io/en/latest/tutorial/introduction.html#numbers

PR: font-size: 75%;

image

https://python-docs-theme-previews--178.org.readthedocs.build/en/178/tutorial/introduction.html#numbers

@Privat33r-dev
Copy link
Contributor Author

Privat33r-dev commented Mar 17, 2024

From one point, it fixes the CSS, from the other point, it makes the element a bit small
image
image

As I was writing, you posted the same thing as well. I think that removal of the text-size property would be more desirable and if 2 people have the same idea independently, I guess that it's a valid point.

P.S. I as well did my life harder by forgetting to make a new branch. Also I will use rebase this time because I forgot to setup my name, email and signing key.

Copy link
Member

@hugovk hugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@pradyunsg What do you think?

@pradyunsg pradyunsg merged commit 540a95c into python:main Mar 17, 2024
9 checks passed
@pradyunsg
Copy link
Member

@pradyunsg What do you think?

Good catch, and looks like this is good to merge! :)

@Privat33r-dev Privat33r-dev changed the title Correct invalid property name Remove incorrect CSS property Mar 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants