Skip to content

Copyedits to PEP 679 #2222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jan 10, 2022
Merged

Copyedits to PEP 679 #2222

merged 7 commits into from
Jan 10, 2022

Conversation

JelleZijlstra
Copy link
Member

No description provided.

Copy link
Member

@hugovk hugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Plus a few others suggestions:

Line 45:

-Although is possible to currently format long ``assert`` statements over
+Although it is possible to currently format long ``assert`` statements over

Line 56:

-the authors of this document believe the parenthesized form is more clear and more consistent with
+the authors of this document believe the parenthesized form is clearer and more consistent with

Also there's a move to discourage references and link directly instead: #2130

So update line 67:

This change has been originally discussed and proposed in [bpo-46167]_.

And line 153 (plus "exist" -> "exists"):

A proposed draft PR with the change exist in [GH-30247]_.

JelleZijlstra and others added 2 commits January 10, 2022 02:12
Co-authored-by: Hugo van Kemenade <[email protected]>
Co-authored-by: Hugo van Kemenade <[email protected]>
@pablogsal
Copy link
Member

Thanks a lot for the edits @JelleZijlstra 🎉

@pablogsal pablogsal merged commit 8b9859a into main Jan 10, 2022
@pablogsal pablogsal deleted the JelleZijlstra-patch-2 branch January 10, 2022 12:28
@JelleZijlstra
Copy link
Member Author

Thanks Pablo! Hugo's other suggestions in the message above are still open but I think better handled in a new PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants