Skip to content

PEP 660: Editable installs for PEP 517 style build backends #1944

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 20, 2021
Merged

PEP 660: Editable installs for PEP 517 style build backends #1944

merged 1 commit into from
May 20, 2021

Conversation

sbidoul
Copy link
Contributor

@sbidoul sbidoul commented May 2, 2021

No description provided.

@sbidoul sbidoul requested a review from a team as a code owner May 2, 2021 10:41
@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

CLA Missing

Our records indicate the following people have not signed the CLA:

@dholth

For legal reasons we need all the people listed to sign the CLA before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

If you have recently signed the CLA, please wait at least one business day
before our records are updated.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

@sbidoul
Copy link
Contributor Author

sbidoul commented May 2, 2021

GitHub apparently brought over the discussion we had in sbidoul#1. I assume this is not an issue.

@pfmoore as sponsor will you assign a PEP number ?
@dholth as the first commit is yours it looks like you need to sign the CLA. Or maybe not if commits are squashed before merging.

@sbidoul sbidoul force-pushed the build_wheel_for_editable-sbi branch 2 times, most recently from 8c5a320 to 2752f4c Compare May 2, 2021 13:00
@pfmoore
Copy link
Member

pfmoore commented May 2, 2021

I'll wait for the CLA from @dholth just to be on the safe side (although I'm surprised he hasn't already signed it, as he was the author of the wheel PEP).

@sbidoul sbidoul changed the title PEP 9999: Editable installs for PEP-517 style build backends PEP 0667: Editable installs for PEP-517 style build backends May 2, 2021
@sbidoul
Copy link
Contributor Author

sbidoul commented May 2, 2021

The CLA issue is suprising indeed because there are several other commits from Daniel with the exact same e-mail address.

I add to change his email in the document itself because the CI complained that some authors have more than one email address listed: Daniel Holth: ['[email protected]', '[email protected]']

I tentatively used number 667 to get a green build.

domdfcoding
domdfcoding reviewed May 2, 2021
View reviewed changes
@Rosuav
Copy link
Contributor

Rosuav commented May 2, 2021

PEP number 657 looks to be available; you should be able to grab that. In the (unlikely) event that someone else grabs that number, you'll get a merge conflict, and can bump it to 658.

@sbidoul sbidoul force-pushed the build_wheel_for_editable-sbi branch from bb3d8a0 to 5bd4514 Compare May 2, 2021 17:08
@pradyunsg
Copy link
Member

And the title too! :P

@sbidoul sbidoul changed the title PEP 0667: Editable installs for PEP-517 style build backends PEP 0667: Editable installs for PEP 517 style build backends May 2, 2021
@sbidoul sbidoul changed the title PEP 0667: Editable installs for PEP 517 style build backends PEP 0657: Editable installs for PEP 517 style build backends May 2, 2021
brettcannon
brettcannon requested changes May 3, 2021
View reviewed changes
Copy link
Member

@brettcannon brettcannon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add Paul in .github/CODEOWNERS for this file as the PEP sponsor.

@brettcannon brettcannon requested a review from pfmoore May 3, 2021 22:46
@brettcannon
Copy link
Member

We also need the CLA to be signed.

pradyunsg
pradyunsg reviewed May 4, 2021
View reviewed changes
pep-0657.rst Outdated
Title: Editable installs for PEP 517 style build backends
Author: Daniel Holth <[email protected]>, Stéphane Bidoul <[email protected]>
Sponsor: Paul Moore <[email protected]>
Discussions-To: https://discuss.python.org/t/draft-pep-editable-installs-for-pep-517-style-build-backends/8510
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Discussions-To: https://discuss.python.org/t/draft-pep-editable-installs-for-pep-517-style-build-backends/8510
Discussions-To: https://discuss.python.org/t/8510

A cleaner URL.

@sbidoul sbidoul force-pushed the build_wheel_for_editable-sbi branch from 5bd4514 to a1ee518 Compare May 4, 2021 07:34
@brettcannon brettcannon requested review from brettcannon and removed request for brettcannon May 4, 2021 19:29
pfmoore
pfmoore requested changes May 4, 2021
View reviewed changes
Copy link
Member

@pfmoore pfmoore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs @dholth to sign the CLA but otherwise it looks OK to me.

@brettcannon brettcannon requested a review from pfmoore May 5, 2021 20:03
@pfmoore
Copy link
Member

pfmoore commented May 5, 2021

@brettcannon All we're waiting on is the CLA. I don't know whether we're allowed to ignore the CLA requirement and merge this, but other than that, I've approved this...

@dholth
Copy link
Contributor

dholth commented May 5, 2021 via email

@sbidoul sbidoul changed the title PEP 0657: Editable installs for PEP 517 style build backends PEP 657: Editable installs for PEP 517 style build backends May 6, 2021
@pradyunsg
Copy link
Member

Given #1950, this likely needs renumbering.

@pradyunsg pradyunsg mentioned this pull request May 8, 2021
Merged
pfmoore
pfmoore requested changes May 8, 2021
View reviewed changes
Copy link
Member

@pfmoore pfmoore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR title and filename will also need changing to reflect the new PEP number.

.github/CODEOWNERS Outdated
@@ -511,6 +511,7 @@ pep-0653.rst @markshannon
pep-0654.rst @1st1 @gvanrossum
pep-0655.rst @gvanrossum
pep-0656.rst @brettcannon
pep-0657.rst @pfmoore
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PEP number 657 has now been taken - can you update this to the next free number? Might be worth waiting until @dholth has got the CLA sorted, so we don't have to keep changing.

pep-0657.rst Outdated
@@ -0,0 +1,212 @@
PEP: 657
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PEP number needs changing here too.

@sbidoul sbidoul force-pushed the build_wheel_for_editable-sbi branch from 7d0488d to f0927bc Compare May 9, 2021 10:11
@JelleZijlstra JelleZijlstra mentioned this pull request May 10, 2021
Merged
@brettcannon
Copy link
Member

More importantly the CLA issue needs to be resolved before fixing the issue number is necessary in case it shifts again.

@pfmoore
Copy link
Member

pfmoore commented May 14, 2021

I'm not going to be able to keep checking this PR - can @dholth or someone else please explicitly @-ping me when the CLA issue is resolved?

@pradyunsg
Copy link
Member

@dholth nudge. Any updates on when you might be able to sign the CLA?

@dholth
Copy link
Contributor

dholth commented May 19, 2021 via email

@sbidoul sbidoul force-pushed the build_wheel_for_editable-sbi branch from 13cb33d to 7ffadee Compare May 20, 2021 07:17
@sbidoul sbidoul changed the title PEP 657: Editable installs for PEP 517 style build backends PEP 660: Editable installs for PEP 517 style build backends May 20, 2021
@sbidoul
Copy link
Contributor Author

sbidoul commented May 20, 2021

Since PEP 1 says commit would be squashed when merging, I took the liberty to squash them before, which incidentally made the red label go away. @dholth if credit in the author field is ok for you and you don't mind too much about the commits, perhaps we can move forward this way.

@brettcannon brettcannon requested a review from pfmoore May 20, 2021 18:57
@brettcannon brettcannon merged commit b875991 into python:master May 20, 2021
@naveen521kk naveen521kk mentioned this pull request May 23, 2021
Merged
12 tasks
frostming
frostming reviewed May 27, 2021
View reviewed changes
pep-0660.rst
What to put in the wheel
------------------------

Build backends may use different techniques to achive the goals of an editable
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A small typo: achieve

@erlend-aasland erlend-aasland mentioned this pull request May 13, 2022
Closed
@erlend-aasland erlend-aasland mentioned this pull request Jun 27, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pradyunsg pradyunsg pradyunsg left review comments

@domdfcoding domdfcoding domdfcoding left review comments

@frostming frostming frostming left review comments

@brettcannon brettcannon brettcannon approved these changes

@isidentical isidentical Awaiting requested review from isidentical

@pablogsal pablogsal Awaiting requested review from pablogsal

@pfmoore pfmoore Awaiting requested review from pfmoore

Assignees
No one assigned
Labels
CLA signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@sbidoul @the-knights-who-say-ni @pfmoore @Rosuav @pradyunsg @brettcannon @dholth @domdfcoding @frostming