Skip to content

PEP-654: use C traceback for some examples #1866

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 11, 2021

Conversation

iritkatriel
Copy link
Member

No description provided.

pep-0654.rst Outdated
Comment on lines 328 to 329
+------------------------------------
+------------------------------------
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These two "outdents" seem superfluous.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we have only one? Or no closing line at all?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there should only be one, and it should be indented with the entry immediately above it.

pep-0654.rst Outdated
Comment on lines 328 to 329
+------------------------------------
+------------------------------------
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there should only be one, and it should be indented with the entry immediately above it.

pep-0654.rst Outdated
| The above exception was the direct cause of the following exception:

|
| Traceback (most recent call last):
| File "<stdin>", line 4, in <module>
| ValueError: bad value
+------------------------------------
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this one be aligned with what's above it? (Also in a few other places.)

There's also a redundant extra line of dashes above on line 794 (GitHub won't let me comment there).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think so too, I probably misunderstood what you meant earlier. Online 802, it should be indented 4 more places so the + is under the |, right?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exactly!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants