-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
PEP-654: use C traceback for some examples #1866
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
pep-0654.rst
Outdated
+------------------------------------ | ||
+------------------------------------ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These two "outdents" seem superfluous.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we have only one? Or no closing line at all?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there should only be one, and it should be indented with the entry immediately above it.
pep-0654.rst
Outdated
+------------------------------------ | ||
+------------------------------------ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there should only be one, and it should be indented with the entry immediately above it.
pep-0654.rst
Outdated
| The above exception was the direct cause of the following exception: | ||
|
||
| | ||
| Traceback (most recent call last): | ||
| File "<stdin>", line 4, in <module> | ||
| ValueError: bad value | ||
+------------------------------------ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't this one be aligned with what's above it? (Also in a few other places.)
There's also a redundant extra line of dashes above on line 794 (GitHub won't let me comment there).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think so too, I probably misunderstood what you meant earlier. Online 802, it should be indented 4 more places so the + is under the |, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Exactly!
No description provided.