bpo-45310: Fix parrallel shared memory tests #28661
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a PID to names of POSIX shared memory objects to allow running multiprocessing tests (test_multiprocessing_fork, test_multiprocessing_spawn, etc) in parallel.
serhiy-storchaka
added
tests
|
🤖 New build scheduled with the buildbot fleet by @serhiy-storchaka for commit 69ebc33 🤖 If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again. |
bedevere-bot
removed
the
🔨 test-with-buildbots
vstinner
reviewed
Sep 30, 2021
vstinner
reviewed
Sep 30, 2021
Comment on lines
+3780
to
+3781
| name_tsmb = self._new_shm_name('test01_tsmb') | ||
| sms = shared_memory.SharedMemory(name_tsmb, create=True, size=512) |
There was a problem hiding this comment.
You may add an helper method which create a name and calls SharedMemory() with it. Or leave the code as it is, it's up to you.
There was a problem hiding this comment.
It is used not only with SharedMemory, but with ShareableList.
There was a problem hiding this comment.
Ah, I didn't notice. It's just a minor coding style suggestion. The code is good as it is.
|
Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10. |
|
Sorry, @serhiy-storchaka, I could not cleanly backport this to |
|
GH-28669 is a backport of this pull request to the 3.10 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Oct 1, 2021
Add a PID to names of POSIX shared memory objects to allow running multiprocessing tests (test_multiprocessing_fork, test_multiprocessing_spawn, etc) in parallel. (cherry picked from commit eb4495e) Co-authored-by: Serhiy Storchaka <[email protected]>
serhiy-storchaka
added a commit
to serhiy-storchaka/cpython
that referenced
this pull request
Oct 1, 2021
Add a PID to names of POSIX shared memory objects to allow running multiprocessing tests (test_multiprocessing_fork, test_multiprocessing_spawn, etc) in parallel.. (cherry picked from commit eb4495e) Co-authored-by: Serhiy Storchaka <[email protected]>
|
GH-28670 is a backport of this pull request to the 3.9 branch. |
|
Thanks for adding the comment, it's useful to me at least ;-) |
serhiy-storchaka
added a commit
that referenced
this pull request
Oct 1, 2021
miss-islington
added a commit
that referenced
this pull request
Oct 1, 2021
Add a PID to names of POSIX shared memory objects to allow running multiprocessing tests (test_multiprocessing_fork, test_multiprocessing_spawn, etc) in parallel. (cherry picked from commit eb4495e) Co-authored-by: Serhiy Storchaka <[email protected]>
|
pablogsal
pushed a commit
that referenced
this pull request
Oct 4, 2021
Add a PID to names of POSIX shared memory objects to allow running multiprocessing tests (test_multiprocessing_fork, test_multiprocessing_spawn, etc) in parallel. (cherry picked from commit eb4495e) Co-authored-by: Serhiy Storchaka <[email protected]>
|
Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8. |
|
Sorry, @serhiy-storchaka, I could not cleanly backport this to |
|
GH-28979 is a backport of this pull request to the 3.8 branch. |
ambv
pushed a commit
that referenced
this pull request
Oct 19, 2021
Add a PID to names of POSIX shared memory objects to allow running multiprocessing tests (test_multiprocessing_fork, test_multiprocessing_spawn, etc) in parallel. (cherry picked from commit eb4495e) Co-authored-by: Serhiy Storchaka <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a PID to names of POSIX shared memory objects to allow
running multiprocessing tests (test_multiprocessing_fork,
test_multiprocessing_spawn, etc) in parallel.
https://bugs.python.org/issue45310