Skip to content

bpo-41521, typing: Rename _PROTO_WHITELIST to _PROTO_ALLOWLIST #21825

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 12, 2020
Merged

bpo-41521, typing: Rename _PROTO_WHITELIST to _PROTO_ALLOWLIST #21825

merged 1 commit into from
Aug 12, 2020

Conversation

vstinner
Copy link
Member

@vstinner vstinner commented Aug 11, 2020

@vstinner
Copy link
Member Author

@gvanrossum @ilevkivskyi:

  • Would you mind to review this change?
  • Is it ok to rename the private typing._PROTO_WHITELIST variable?
  • Should we keep an alias (_PROTO_WHITELIST = _PROTO_ALLOWLIST) during 1 or 2 releases?
  • Should I document this change change in a NEWS entry?

@vstinner
Copy link
Member Author

FYI I also renamed one test_typing test in commit 0ee0b29.

@gvanrossum
Copy link
Member

I prefer not to do this. I find it linguistically awkward, and reading the history of “blacklist” on Wikipedia I don’t see any connection with racism. https://en.m.wikipedia.org/wiki/Blacklisting

@tiran
Copy link
Member

tiran commented Aug 11, 2020

I prefer not to do this. I find it linguistically awkward, and reading the history of “blacklist” on Wikipedia I don’t see any connection with racism. en.m.wikipedia.org/wiki/Blacklisting

Yes, the term is not racist. It's more subtle. The negative co-notation of black is death by a thousand paper cuts. The great Muhammad Ali explained this in multiple interviews, e.g. https://www.youtube.com/watch?v=7eXdt1eGgCA

@gvanrossum
Copy link
Member

Then someone else can approve this. I hope you understand.

@ambv ambv merged commit 0e95bbf into python:master Aug 12, 2020
@bedevere-bot
Copy link

@ambv: Please replace # with GH- in the commit message next time. Thanks!

shihai1991 pushed a commit to shihai1991/cpython that referenced this pull request Aug 20, 2020
xzy3 pushed a commit to xzy3/cpython that referenced this pull request Oct 18, 2020
@vstinner vstinner deleted the allowlist_typing branch January 19, 2021 21:51
YouJiacheng added a commit to YouJiacheng/typing_extensions that referenced this pull request Mar 28, 2023
and rename _PROTO_WHITELIST to _PROTO_ALLOWLIST

taken from python/cpython#15647 and python/cpython#21825
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants