Skip to content

gh-98388: add tests for happy eyeballs #136368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 7, 2025
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
88 changes: 88 additions & 0 deletions Lib/test/test_asyncio/test_base_events.py
Original file line number Diff line number Diff line change
Expand Up @@ -150,6 +150,29 @@ def test_ipaddr_info_no_inet_pton(self, m_socket):
socket.SOCK_STREAM,
socket.IPPROTO_TCP))

def test_interleave_addrinfos(self):
self.maxDiff = None
SIX_A = (socket.AF_INET6, 0, 0, '', ('2001:db8::1', 1))
SIX_B = (socket.AF_INET6, 0, 0, '', ('2001:db8::2', 2))
SIX_C = (socket.AF_INET6, 0, 0, '', ('2001:db8::3', 3))
SIX_D = (socket.AF_INET6, 0, 0, '', ('2001:db8::4', 4))
FOUR_A = (socket.AF_INET, 0, 0, '', ('192.0.2.1', 5))
FOUR_B = (socket.AF_INET, 0, 0, '', ('192.0.2.2', 6))
FOUR_C = (socket.AF_INET, 0, 0, '', ('192.0.2.3', 7))
FOUR_D = (socket.AF_INET, 0, 0, '', ('192.0.2.4', 8))

addrinfos = [SIX_A, SIX_B, SIX_C, FOUR_A, FOUR_B, FOUR_C, FOUR_D, SIX_D]
expected = [SIX_A, FOUR_A, SIX_B, FOUR_B, SIX_C, FOUR_C, SIX_D, FOUR_D]

self.assertEqual(expected, base_events._interleave_addrinfos(addrinfos))

expected_fafc_2 = [SIX_A, SIX_B, FOUR_A, SIX_C, FOUR_B, SIX_D, FOUR_C, FOUR_D]
self.assertEqual(
expected_fafc_2,
base_events._interleave_addrinfos(addrinfos, first_address_family_count=2),
)



class BaseEventLoopTests(test_utils.TestCase):

Expand Down Expand Up @@ -1053,6 +1076,71 @@ def test_asyncgen_finalization_by_gc_in_other_thread(self):
test_utils.run_briefly(self.loop)
self.assertTrue(status['finalized'])

@unittest.skipUnless(socket_helper.IPV6_ENABLED, 'no IPv6 support')
@patch_socket
def test_create_connection_happy_eyeballs(self, m_socket):

class MyProto(asyncio.Protocol):
pass

async def getaddrinfo(*args, **kw):
return [(socket.AF_INET6, 0, 0, '', ('2001:db8::1', 1)),
(socket.AF_INET, 0, 0, '', ('192.0.2.1', 5))]

async def sock_connect(sock, address):
if address[0] == '2001:db8::1':
await asyncio.sleep(1)
sock.connect(address)

loop = asyncio.new_event_loop()
loop._add_writer = mock.Mock()
loop._add_writer = mock.Mock()
loop._add_reader = mock.Mock()
loop.getaddrinfo = getaddrinfo
loop.sock_connect = sock_connect

coro = loop.create_connection(MyProto, 'example.com', 80, happy_eyeballs_delay=0.3)
transport, protocol = loop.run_until_complete(coro)
try:
sock = transport._sock
sock.connect.assert_called_with(('192.0.2.1', 5))
finally:
transport.close()
test_utils.run_briefly(loop) # allow transport to close
loop.close()

@patch_socket
def test_create_connection_happy_eyeballs_ipv4_only(self, m_socket):

class MyProto(asyncio.Protocol):
pass

async def getaddrinfo(*args, **kw):
return [(socket.AF_INET, 0, 0, '', ('192.0.2.1', 5)),
(socket.AF_INET, 0, 0, '', ('192.0.2.2', 6))]

async def sock_connect(sock, address):
if address[0] == '192.0.2.1':
await asyncio.sleep(1)
sock.connect(address)

loop = asyncio.new_event_loop()
loop._add_writer = mock.Mock()
loop._add_writer = mock.Mock()
loop._add_reader = mock.Mock()
loop.getaddrinfo = getaddrinfo
loop.sock_connect = sock_connect

coro = loop.create_connection(MyProto, 'example.com', 80, happy_eyeballs_delay=0.3)
transport, protocol = loop.run_until_complete(coro)
try:
sock = transport._sock
sock.connect.assert_called_with(('192.0.2.2', 6))
finally:
transport.close()
test_utils.run_briefly(loop) # allow transport to close
loop.close()


class MyProto(asyncio.Protocol):
done = None
Expand Down
Loading