Skip to content

gh-136032: Fix argparse.BooleanOptionalAction doc #136133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jul 5, 2025
Merged

gh-136032: Fix argparse.BooleanOptionalAction doc #136133

merged 5 commits into from
Jul 5, 2025
+20 −17

Conversation

mattwang44
Copy link
Contributor

@mattwang44 mattwang44 commented Jun 30, 2025 •
edited by github-actions bot
Loading

@bedevere-app bedevere-app bot added awaiting review docs Documentation in the Doc dir skip news labels Jun 30, 2025
@github-project-automation github-project-automation bot moved this to Todo in Docs PRs Jun 30, 2025
@bedevere-app bedevere-app bot mentioned this pull request Jun 30, 2025
Open
@mattwang44 mattwang44 force-pushed the fix-argparse-BooleanOptionalAction-doc branch from 075b1c9 to e4b9fd5 Compare June 30, 2025 14:57
mattwang44
mattwang44 commented Jun 30, 2025
View reviewed changes
savannahostrowski
savannahostrowski requested changes Jul 1, 2025
View reviewed changes
Copy link
Member

@savannahostrowski savannahostrowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR. I think your suggestion to move BooleanOptionalAction is solid. Wording is also great, just one small comment

@bedevere-app
Copy link

bedevere-app bot commented Jul 1, 2025

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@mattwang44
Copy link
Contributor Author

I have made the requested changes; please review again

@bedevere-app
Copy link

bedevere-app bot commented Jul 1, 2025

Thanks for making the requested changes!

@savannahostrowski: please review the changes made to this pull request.

@bedevere-app bedevere-app bot requested a review from savannahostrowski July 1, 2025 07:03
serhiy-storchaka
serhiy-storchaka reviewed Jul 3, 2025
View reviewed changes
Copy link
Member

@serhiy-storchaka serhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is much clearer than the old documentation.

@mattwang44 mattwang44 force-pushed the fix-argparse-BooleanOptionalAction-doc branch from d618477 to fbd30a5 Compare July 3, 2025 19:28
serhiy-storchaka
serhiy-storchaka approved these changes Jul 3, 2025
View reviewed changes
Copy link
Member

@serhiy-storchaka serhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 👍

For future, please avoid rebase and force-push. It is easier to review if you can see only new changes.

@savannahostrowski savannahostrowski added the needs backport to 3.13 bugs and security fixes label Jul 5, 2025
@savannahostrowski savannahostrowski added the needs backport to 3.14 bugs and security fixes label Jul 5, 2025
savannahostrowski
savannahostrowski approved these changes Jul 5, 2025
View reviewed changes
Copy link
Member

@savannahostrowski savannahostrowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome - thanks so much for this!

@savannahostrowski savannahostrowski merged commit 1953713 into python:main Jul 5, 2025
29 checks passed
@github-project-automation github-project-automation bot moved this from Todo to Done in Docs PRs Jul 5, 2025
@miss-islington-app
Copy link

Thanks @mattwang44 for the PR, and @savannahostrowski for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 5, 2025
@mattwang44 @miss-islington
pythongh-136032: Fix argparse.BooleanOptionalAction doc (pythonGH-1…
85bc430 
…36133)

(cherry picked from commit 1953713)

Co-authored-by: W. H. Wang <[email protected]>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 5, 2025
@mattwang44 @miss-islington
pythongh-136032: Fix argparse.BooleanOptionalAction doc (pythonGH-1…
d318b9a 
…36133)

(cherry picked from commit 1953713)

Co-authored-by: W. H. Wang <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented Jul 5, 2025

GH-136329 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.14 bugs and security fixes label Jul 5, 2025
@bedevere-app
Copy link

bedevere-app bot commented Jul 5, 2025

GH-136330 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Jul 5, 2025
@mattwang44 mattwang44 deleted the fix-argparse-BooleanOptionalAction-doc branch July 6, 2025 01:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

@savannahostrowski savannahostrowski savannahostrowski approved these changes

Assignees
No one assigned
Labels
docs Documentation in the Doc dir skip news
Projects
Docs PRs
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mattwang44 @serhiy-storchaka @savannahostrowski