GH-133261: Make sure trashcan pointers look mortal -- 32 bit #133450
Conversation
markshannon
commented
May 5, 2025
•
markshannon
commented
- Issue: test_frame does crash randomly on Linux (x86-64, ppc64le, s390x) #133261
|
!buildbot "x86 Debian" |
|
The regex '"x86 Debian"' did not match any buildbot builder. Is the requested builder in the list of stable builders? |
|
!buildbot x86 Debian |
|
🤖 New build scheduled with the buildbot fleet by @markshannon for commit 2ef7ee5 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F133450%2Fmerge The command will test the builders whose names match following regular expression: The builders matched are:
|
markshannon
changed the title
| if (refcnt & 1) { | ||
| refcnt += _Py_IMMORTAL_MINIMUM_REFCNT - 1; | ||
| } | ||
| return (void *)(refcnt - 2); | ||
| #else | ||
| return (void *)((refcnt -1) << 2); |
There was a problem hiding this comment.
| return (void *)((refcnt -1) << 2); | |
| return (void *)((refcnt - 1) << 2); |
Nice, the fix works as expected, tests passed on two buildbot workers. |
|
I built Python using I built Python in a x86 (32-bit) container, but I failed to reproduce the issue. But this change looks correct, it should fix the issue, and the buildbots confirmed that the fix works. |
