gh-133367: Add missing options to `ast` CLI #133369

donBarbos · 2025-05-04T10:14:42Z

I wasn't sure about adding whatsnew entry but I added it so we can remote it

*Headings were corrected according to the devguide

cc @sobolevn

Issue: Improve ast CLI with new options: --feature-version, --optimize, and --show-empty #133367

📚 Documentation preview 📚: https://cpython-previews--133369.org.readthedocs.build/

sobolevn

Please, don't forget to add tests in your other PR

Doc/library/ast.rst

Lib/ast.py

Doc/library/ast.rst

skirpichev · 2025-05-04T11:47:34Z

Please, don't forget to add tests in your other PR

Probably, that one (i.e. #133329) should be merged first.

StanFromIreland

Some docs notes

Doc/library/ast.rst

Co-authored-by: Stan Ulbrych <[email protected]>

Doc/whatsnew/3.14.rst

Lib/ast.py

sobolevn

Now please rebase this PR and add tests :)

Misc/NEWS.d/next/Library/2025-05-04-13-40-05.gh-issue-133367.E5nl2u.rst

…5nl2u.rst Co-authored-by: Stan Ulbrych <[email protected]>

Doc/library/ast.rst

Lib/ast.py

Doc/library/ast.rst

sobolevn

LGTM

sobolevn

One more suggestion: let's add defaults to the docs.

Doc/library/ast.rst

sobolevn

Thank you! 🎉

Doc/library/ast.rst

pythongh-133367: Add missing options to ast CLI

783fb15

donBarbos requested review from isidentical, JelleZijlstra and Eclips4 as code owners May 4, 2025 10:14

bedevere-app bot mentioned this pull request May 4, 2025

Improve ast CLI with new options: --feature-version, --optimize, and --show-empty #133367

Closed

bedevere-app bot added the awaiting review label May 4, 2025

doc fix

3138d2e

skirpichev requested a review from sobolevn May 4, 2025 10:37

sobolevn reviewed May 4, 2025

View reviewed changes

Doc/library/ast.rst Outdated Show resolved Hide resolved

Lib/ast.py Outdated Show resolved Hide resolved

Add .. versionadded:: directive

5a2433f

tomasr8 reviewed May 4, 2025

View reviewed changes

Doc/library/ast.rst Outdated Show resolved Hide resolved

Doc/library/ast.rst Outdated Show resolved Hide resolved

Update --feature-version option

8fe372a

JelleZijlstra approved these changes May 4, 2025

View reviewed changes

bedevere-app bot added awaiting merge and removed awaiting review labels May 4, 2025

StanFromIreland reviewed May 4, 2025

View reviewed changes

Doc/library/ast.rst Outdated Show resolved Hide resolved

Doc/library/ast.rst Outdated Show resolved Hide resolved

Doc/library/ast.rst Show resolved Hide resolved

Doc/library/ast.rst Outdated Show resolved Hide resolved

donBarbos and others added 2 commits May 4, 2025 16:46

Apply suggestions from code review

c296107

Co-authored-by: Stan Ulbrych <[email protected]>

Revert "add gaps"

af4d1c3

picnixz reviewed May 4, 2025

View reviewed changes

Doc/whatsnew/3.14.rst Show resolved Hide resolved

Lib/ast.py Outdated Show resolved Hide resolved

Change flag alias

de65026

sobolevn reviewed May 4, 2025

View reviewed changes

StanFromIreland reviewed May 4, 2025

View reviewed changes

Misc/NEWS.d/next/Library/2025-05-04-13-40-05.gh-issue-133367.E5nl2u.rst Outdated Show resolved Hide resolved

donBarbos and others added 2 commits May 5, 2025 02:26

Merge branch 'main' into issue-133367

1b2e538

Update Misc/NEWS.d/next/Library/2025-05-04-13-40-05.gh-issue-133367.E…

6aac4bf

…5nl2u.rst Co-authored-by: Stan Ulbrych <[email protected]>

sobolevn requested a review from hugovk May 4, 2025 22:47

Add tests

948b453

hugovk approved these changes May 5, 2025

View reviewed changes

Doc/library/ast.rst Outdated Show resolved Hide resolved

Lib/ast.py Outdated Show resolved Hide resolved

Lib/ast.py Outdated Show resolved Hide resolved

Doc/library/ast.rst Show resolved Hide resolved

Accept suggestions

f2d0e39

sobolevn approved these changes May 5, 2025

View reviewed changes

Doc/library/ast.rst Outdated Show resolved Hide resolved

Doc/library/ast.rst Outdated Show resolved Hide resolved

Doc/library/ast.rst Outdated Show resolved Hide resolved

Add default to options

d5921da

sobolevn approved these changes May 5, 2025

View reviewed changes

sobolevn reviewed May 5, 2025

View reviewed changes

Doc/library/ast.rst Outdated Show resolved Hide resolved

Update Doc/library/ast.rst

d6d9c22

sobolevn enabled auto-merge (squash) May 5, 2025 16:55

sobolevn merged commit 2b4e2b7 into python:main May 5, 2025
39 checks passed

bedevere-app bot removed the awaiting merge label May 5, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

gh-133367: Add missing options to `ast` CLI #133369

gh-133367: Add missing options to `ast` CLI #133369

donBarbos commented May 4, 2025 •

edited by github-actions bot

Loading

sobolevn left a comment

skirpichev commented May 4, 2025

StanFromIreland left a comment

sobolevn left a comment

sobolevn left a comment

sobolevn left a comment

sobolevn left a comment

gh-133367: Add missing options to ast CLI #133369

gh-133367: Add missing options to ast CLI #133369

Conversation

donBarbos commented May 4, 2025 • edited by github-actions bot Loading

sobolevn left a comment

Choose a reason for hiding this comment

skirpichev commented May 4, 2025

StanFromIreland left a comment

Choose a reason for hiding this comment

sobolevn left a comment

Choose a reason for hiding this comment

sobolevn left a comment

Choose a reason for hiding this comment

sobolevn left a comment

Choose a reason for hiding this comment

sobolevn left a comment

Choose a reason for hiding this comment

gh-133367: Add missing options to `ast` CLI #133369

gh-133367: Add missing options to `ast` CLI #133369

donBarbos commented May 4, 2025 •

edited by github-actions bot

Loading