gh-130197: Test pygettext output option
#133041
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
StanFromIreland
commented
Apr 27, 2025
•
StanFromIreland
commented
- Issue: pygettext: Improve test coverage #130197
18 tasks
tomasr8
reviewed
Apr 27, 2025
|
It should, and output should only be generated if there are msgids, but that is beyond the scope of the pr. I can open an issue for the discussion of this. |
Definitely, I just found it surprising looking at the test and wondering where the input file is 😄 I think the input file should be required, could you open an issue? |
This comment was marked as resolved.
This comment was marked as resolved.
|
How is it broken? It outputs to stdout, no? |
This comment was marked as resolved.
This comment was marked as resolved.
serhiy-storchaka
approved these changes
May 1, 2025
serhiy-storchaka
added
awaiting merge
needs backport to 3.13
|
Thanks @StanFromIreland for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
May 1, 2025
(cherry picked from commit e5e51bd) Co-authored-by: Stan Ulbrych <[email protected]>
|
GH-133266 is a backport of this pull request to the 3.13 branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.